Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-08-01 Thread Theodore Y. Ts'o
On Mon, Jul 30, 2018 at 06:07:47PM +, Jeremy Cline wrote: > 'ac->ac_g_ex.fe_len' is a user-controlled value which is used in the > derivation of 'ac->ac_2order'. 'ac->ac_2order', in turn, is used to > index arrays which makes it a potential spectre gadget. Fix this by > sanitizing the value ass

Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-07-30 Thread Theodore Y. Ts'o
On Mon, Jul 30, 2018 at 02:46:59PM -0400, Jeremy Cline wrote: > I dropped patch 1/3 and 2/3 from the original series because they can > both be covered by some sanitation in fs/quota/quota.c, so the this is > only patch from the v1 series that should be applied. > > Sorry for not being more clear!

Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-07-30 Thread Josh Poimboeuf
On Mon, Jul 30, 2018 at 06:07:47PM +, Jeremy Cline wrote: > 'ac->ac_g_ex.fe_len' is a user-controlled value which is used in the > derivation of 'ac->ac_2order'. 'ac->ac_2order', in turn, is used to > index arrays which makes it a potential spectre gadget. Fix this by > sanitizing the value ass

Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-07-30 Thread Jeremy Cline
Hi Ted, On 07/30/2018 02:36 PM, Theodore Y. Ts'o wrote: > Hey Jeremy, > > I think you are also going to be changing the 1/3 patch from the > original patch series that this was part of. That's correct, right? > > It would be easier for me if you could simply make all of the > revisions you plan

Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-07-30 Thread Theodore Y. Ts'o
Hey Jeremy, I think you are also going to be changing the 1/3 patch from the original patch series that this was part of. That's correct, right? It would be easier for me if you could simply make all of the revisions you plan to make for the patch series, and then upload a full v2 of the entire

[PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-07-30 Thread Jeremy Cline
'ac->ac_g_ex.fe_len' is a user-controlled value which is used in the derivation of 'ac->ac_2order'. 'ac->ac_2order', in turn, is used to index arrays which makes it a potential spectre gadget. Fix this by sanitizing the value assigned to 'ac->ac2_order'. This covers the following accesses found wi