Re: [PATCH v2] ext4: cond_resched in work-heavy group loops

2019-04-25 Thread Theodore Ts'o
On Tue, Apr 23, 2019 at 02:13:29PM -0700, Khazhismel Kumykov wrote: > These functions may take a long time looping over many groups, which > may cause issues for non-preempt kernels. > ext4_mb_init_backend() > ext4_setup_system_zone() > ext4_mb_release() > > Signed-off-by: Khazhismel Kumykov Tha

Re: [PATCH v2] ext4: cond_resched in work-heavy group loops

2019-04-23 Thread Andreas Dilger
On Apr 23, 2019, at 11:13 PM, Khazhismel Kumykov wrote: > > These functions may take a long time looping over many groups, which > may cause issues for non-preempt kernels. > ext4_mb_init_backend() > ext4_setup_system_zone() > ext4_mb_release() > > Signed-off-by: Khazhismel Kumykov Reviewed-by

[PATCH v2] ext4: cond_resched in work-heavy group loops

2019-04-23 Thread Khazhismel Kumykov
These functions may take a long time looping over many groups, which may cause issues for non-preempt kernels. ext4_mb_init_backend() ext4_setup_system_zone() ext4_mb_release() Signed-off-by: Khazhismel Kumykov --- v2: - a few other places that in testing showed to be slow fs/ext4/block_valid