Re: [PATCH v2] ext4: bad mount opts in no journal mode

2019-04-30 Thread Theodore Ts'o
On Mon, Apr 29, 2019 at 01:31:58PM -0400, Debabrata Banerjee wrote: > Fixes: > commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal") > > Instead of removing EXT4_MOUNT_JOURNAL_CHECKSUM from s_def_mount_opt as > I assume was intended, all other options were blown away leading t

Re: [PATCH v2] ext4: bad mount opts in no journal mode

2019-04-29 Thread Jan Kara
On Mon 29-04-19 13:31:58, Debabrata Banerjee wrote: > Fixes: > commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal") > > Instead of removing EXT4_MOUNT_JOURNAL_CHECKSUM from s_def_mount_opt as > I assume was intended, all other options were blown away leading to > _ext4_show_o

[PATCH v2] ext4: bad mount opts in no journal mode

2019-04-29 Thread Debabrata Banerjee
Fixes: commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal") Instead of removing EXT4_MOUNT_JOURNAL_CHECKSUM from s_def_mount_opt as I assume was intended, all other options were blown away leading to _ext4_show_options() output being incorrect. Signed-off-by: Debabrata Baner