Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-09 Thread Francois Romieu
Alexey Brodkin : > On 06/08/2013 12:33 AM, Francois Romieu wrote: > > Alexey Brodkin : [...] > As replied to Joe I just want to name people contributed in this driver. > What is a appropriate way to do it? A polite way could be to see with contributors if it's ok for them to appear in the (c) s

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-09 Thread Andy Shevchenko
On Fri, Jun 7, 2013 at 6:07 PM, Alexey Brodkin wrote: > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > ARCAngel4/ML50x. > > This is based off of current Linus tree, build tested for x86. > +++ b/drivers/net/ether

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-09 Thread Alexey Brodkin
On 06/08/2013 12:33 AM, Francois Romieu wrote: > Alexey Brodkin : [] >> + * Vineet Gupta: Nov 2009 >> + * -Rewrote the driver register access macros so that multiple accesses >> + * in same function use "anchor" reg to save the base addr causing >> + * shorter instructions > > The ker

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-08 Thread Alexey Brodkin
On 06/07/2013 10:13 PM, Joe Perches wrote: > On Fri, 2013-06-07 at 19:07 +0400, Alexey Brodkin wrote: >> Driver for non-standard on-chip ethernet device ARC EMAC 10/100, >> instantiated in some legacy ARC (Synopsys) FPGA Boards such as >> ARCAngel4/ML50x. > > trivial comments only: > >> dif

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-08 Thread Vineet Gupta
On 06/08/2013 04:49 PM, Alexey Brodkin wrote: > >> + if (!priv->phy_node) { > >> + dev_err(&pdev->dev, "failed to retrieve phy description " > >> + "from device tree\n"); > > > > Coalesce formats please > > Could you please clarify how should I format lines in question?

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Francois Romieu
Alexey Brodkin : [...] > diff --git a/drivers/net/ethernet/arc/arc_emac_main.c > b/drivers/net/ethernet/arc/arc_emac_main.c > new file mode 100644 > index 000..f098a27 > --- /dev/null > +++ b/drivers/net/ethernet/arc/arc_emac_main.c > @@ -0,0 +1,956 @@ > +/* > + * Copyright (C) 2004, 2007-201

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Joe Perches
On Fri, 2013-06-07 at 19:07 +0400, Alexey Brodkin wrote: > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > ARCAngel4/ML50x. trivial comments only: > diff --git a/drivers/net/ethernet/arc/arc_emac_main.c > b/drive

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Arnd Bergmann
On Friday 07 June 2013, Alexey Brodkin wrote: > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > ARCAngel4/ML50x. > > This is based off of current Linus tree, build tested for x86. > > Signed-off-by: Alexey Brodkin

[PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Alexey Brodkin
Driver for non-standard on-chip ethernet device ARC EMAC 10/100, instantiated in some legacy ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x. This is based off of current Linus tree, build tested for x86. Signed-off-by: Alexey Brodkin Reviewed-by: Vineet Gupta Reviewed-by: Mischa Jonker Cc