Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread Konrad Rzeszutek Wilk
On Wed, Apr 03, 2013 at 03:34:16PM +0100, Jan Beulich wrote: > >>> On 03.04.13 at 15:56, William Dauchy wrote: > > On Wed, Apr 3, 2013 at 3:42 PM, Jan Beulich wrote: > >> ChangeLog-3.8.3 for example has > > > > oh sorry, you are right. I wasn't looking is the 3.8.x branch. > > The thing is, the

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread Jan Beulich
>>> On 03.04.13 at 15:56, William Dauchy wrote: > On Wed, Apr 3, 2013 at 3:42 PM, Jan Beulich wrote: >> ChangeLog-3.8.3 for example has > > oh sorry, you are right. I wasn't looking is the 3.8.x branch. > The thing is, the revert seems present only in 3.8.x branch. For > example in 3.4.x the las

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread William Dauchy
On Wed, Apr 3, 2013 at 3:42 PM, Jan Beulich wrote: > ChangeLog-3.8.3 for example has oh sorry, you are right. I wasn't looking is the 3.8.x branch. The thing is, the revert seems present only in 3.8.x branch. For example in 3.4.x the last patch is still 01c681d Should we consider this normal or i

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread Jan Beulich
>>> On 03.04.13 at 15:25, William Dauchy wrote: > On Wed, Apr 3, 2013 at 3:01 PM, Jan Beulich wrote: >> Iirc we requested the earlier commit to be removed from stable >> trees, and I think Greg also did so. > > I'm sorry but I'm unable to find a revert of 01c681d in stable tree. ChangeLog-3.8.3

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread William Dauchy
Hello Jan, On Wed, Apr 3, 2013 at 3:01 PM, Jan Beulich wrote: > Iirc we requested the earlier commit to be removed from stable > trees, and I think Greg also did so. I'm sorry but I'm unable to find a revert of 01c681d in stable tree. Regards, -- William -- To unsubscribe from this list: send t

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread Jan Beulich
>>> On 03.04.13 at 14:56, William Dauchy wrote: > On Thu, Feb 28, 2013 at 3:34 AM, Chen Gang wrote: >> additional information: >> before commit 01c681d4c70d64cb72142a2823f27c4146a02e63, the value printed >> here was bogus, as it was the guest provided value from req->u.rw.handle >> rather t

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-04-03 Thread William Dauchy
Hello, On Thu, Feb 28, 2013 at 3:34 AM, Chen Gang wrote: > additional information: > before commit 01c681d4c70d64cb72142a2823f27c4146a02e63, the value printed > here was bogus, as it was the guest provided value from req->u.rw.handle > rather than the actual device. > > Signed-off-by: Chen

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-03-04 Thread Chen Gang
于 2013年03月01日 21:43, Konrad Rzeszutek Wilk 写道: > On Thu, Feb 28, 2013 at 10:34:23AM +0800, Chen Gang wrote: >> >> if call xen_vbd_translate failed, the preq.dev will be not initialized. >> so use blkif->vbd.pdevice instead (still better to print relative info). >> >> additional information: >>

Re: [PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-03-01 Thread Konrad Rzeszutek Wilk
On Thu, Feb 28, 2013 at 10:34:23AM +0800, Chen Gang wrote: > > if call xen_vbd_translate failed, the preq.dev will be not initialized. > so use blkif->vbd.pdevice instead (still better to print relative info). > > additional information: > before commit 01c681d4c70d64cb72142a2823f27c4146a02

[PATCH v2] drivers/block/xen-blkback: preq.dev is used without initialized

2013-02-27 Thread Chen Gang
if call xen_vbd_translate failed, the preq.dev will be not initialized. so use blkif->vbd.pdevice instead (still better to print relative info). additional information: before commit 01c681d4c70d64cb72142a2823f27c4146a02e63, the value printed here was bogus, as it was the guest provided v