Re: [PATCH v2] crypto: hisilicon - allow smaller reads in debugfs

2020-06-18 Thread Herbert Xu
On Tue, Jun 02, 2020 at 04:54:09PM +0300, Dan Carpenter wrote: > Originally this code rejected any read less than 256 bytes. There > is no need for this artificial limit. We should just use the normal > helper functions to read a string from the kernel. > > Signed-off-by: Dan Carpenter > --- >

Re: [PATCH v2] crypto: hisilicon - allow smaller reads in debugfs

2020-06-05 Thread Dan Carpenter
On Fri, Jun 05, 2020 at 09:19:53AM +0800, Shukun Tan wrote: > Hi Dan, > > On 2020/6/2 21:54, Dan Carpenter wrote: > > Originally this code rejected any read less than 256 bytes. There > > is no need for this artificial limit. We should just use the normal > > helper functions to read a string fr

Re: [PATCH v2] crypto: hisilicon - allow smaller reads in debugfs

2020-06-04 Thread Shukun Tan
Hi Dan, On 2020/6/2 21:54, Dan Carpenter wrote: > Originally this code rejected any read less than 256 bytes. There > is no need for this artificial limit. We should just use the normal > helper functions to read a string from the kernel. > > Signed-off-by: Dan Carpenter > --- > v2: Use simple

[PATCH v2] crypto: hisilicon - allow smaller reads in debugfs

2020-06-02 Thread Dan Carpenter
Originally this code rejected any read less than 256 bytes. There is no need for this artificial limit. We should just use the normal helper functions to read a string from the kernel. Signed-off-by: Dan Carpenter --- v2: Use simple_read_from_buffer(). The v1 was slightly half arsed because I