Re: [PATCH v2] crypto: crc32c-pclmul - Shrink K_table to 32-bit words

2014-05-29 Thread Tim Chen
On Wed, 2014-05-28 at 23:26 -0400, George Spelvin wrote: > > Can you do a tcrypt speed measurement with and without your changes? > > Check to see if there's any slowdown. Please make sure you pin > > the frequency of your cpu when running the test. > > > > e.g. > > echo performance > /sys/devi

Re: [PATCH v2] crypto: crc32c-pclmul - Shrink K_table to 32-bit words

2014-05-28 Thread George Spelvin
> Can you do a tcrypt speed measurement with and without your changes? > Check to see if there's any slowdown. Please make sure you pin > the frequency of your cpu when running the test. > > e.g. > echo performance > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor I just now re-read your

Re: [PATCH v2] crypto: crc32c-pclmul - Shrink K_table to 32-bit words

2014-05-28 Thread George Spelvin
> Can you do a tcrypt speed measurement with and without your changes? > Check to see if there's any slowdown. Please make sure you pin > the frequency of your cpu when running the test. Sure thing; I was already inspired to do that based on your concerns. Do you have any particular buffer size

Re: [PATCH v2] crypto: crc32c-pclmul - Shrink K_table to 32-bit words

2014-05-28 Thread Tim Chen
On Wed, 2014-05-28 at 18:15 -0400, George Spelvin wrote: > crypto: crc32c-pclmul - Shrink K_table to 32-bit words > > There's no need for the K_table to be made of 64-bit words. For some > reason, the original authors didn't fully reduce the values modulo the > CRC32C polynomial, and so had some

[PATCH v2] crypto: crc32c-pclmul - Shrink K_table to 32-bit words

2014-05-28 Thread George Spelvin
crypto: crc32c-pclmul - Shrink K_table to 32-bit words There's no need for the K_table to be made of 64-bit words. For some reason, the original authors didn't fully reduce the values modulo the CRC32C polynomial, and so had some 33-bit number in there. They can all be reduced to 32 bits. Doing