Re: [PATCH v2] cpuset sched_load_balance flag

2007-10-10 Thread Paul Jackson
> > + doms = kmalloc(sizeof(cpumask_t), GFP_KERNEL); > > + *doms = top_cpuset.cpus_allowed; > > We generally only excuse failure to check kmalloc return value when the > code is called on the bootup path. But this code is called at other times. > > > > > ... > > + doms_cur

Re: [PATCH v2] cpuset sched_load_balance flag

2007-10-10 Thread Andrew Morton
On Sat, 06 Oct 2007 02:47:47 -0700 Paul Jackson <[EMAIL PROTECTED]> wrote: > From: Paul Jackson <[EMAIL PROTECTED]> > > Add a new per-cpuset flag called 'sched_load_balance'. > > When enabled in a cpuset (the default value) it tells the kernel > scheduler that the scheduler should provide the no

Re: [PATCH v2] cpuset sched_load_balance flag

2007-10-06 Thread Ingo Molnar
* Paul Jackson <[EMAIL PROTECTED]> wrote: > From: Paul Jackson <[EMAIL PROTECTED]> > > Add a new per-cpuset flag called 'sched_load_balance'. [...] > See further the Documentation and comments in the code itself. > > Signed-off-by: Paul Jackson <[EMAIL PROTECTED]> Acked-by: Ingo Molnar <[EMAI

[PATCH v2] cpuset sched_load_balance flag

2007-10-06 Thread Paul Jackson
From: Paul Jackson <[EMAIL PROTECTED]> Add a new per-cpuset flag called 'sched_load_balance'. When enabled in a cpuset (the default value) it tells the kernel scheduler that the scheduler should provide the normal load balancing on the CPUs in that cpuset, sometimes moving tasks from one CPU to a