Re: [PATCH v2] clk: mediatek: Initialize clk_init_data

2015-05-18 Thread Ricky Liang
Hi Sascha, Sure. I can fix clk-gate.c as well. New patch on the way... -Ricky On Mon, May 18, 2015 at 1:54 PM, Sascha Hauer wrote: > Hi Ricky, > > On Mon, May 18, 2015 at 11:41:49AM +0800, Ricky Liang wrote: >> The variable init (struct clk_init_data) is allocated on the stack. >> We weren't in

Re: [PATCH v2] clk: mediatek: Initialize clk_init_data

2015-05-17 Thread Sascha Hauer
Hi Ricky, On Mon, May 18, 2015 at 11:41:49AM +0800, Ricky Liang wrote: > The variable init (struct clk_init_data) is allocated on the stack. > We weren't initializing the .flags field, so it contains random junk, > which can cause all kinds of interesting issues when the flags are > parsed by clk_

[PATCH v2] clk: mediatek: Initialize clk_init_data

2015-05-17 Thread Ricky Liang
The variable init (struct clk_init_data) is allocated on the stack. We weren't initializing the .flags field, so it contains random junk, which can cause all kinds of interesting issues when the flags are parsed by clk_register. Signed-off-by: Ricky Liang --- drivers/clk/mediatek/clk-pll.c | 2 +