Re: [PATCH v2] clk: check the actual phase if get_phase is provided

2016-02-28 Thread Shawn Lin
On 2016/2/27 8:10, Stephen Boyd wrote: On 02/26, Shawn Lin wrote: On 2016/2/26 7:14, Stephen Boyd wrote: On 02/18, Shawn Lin wrote: set_phase does sanity checking of degree and ask sub-driver [...] already there. Signed-off-by: Shawn Lin --- Knee jerk reaction is why does the provider

Re: [PATCH v2] clk: check the actual phase if get_phase is provided

2016-02-26 Thread Stephen Boyd
On 02/26, Shawn Lin wrote: > On 2016/2/26 7:14, Stephen Boyd wrote: > >On 02/18, Shawn Lin wrote: > >>set_phase does sanity checking of degree and ask sub-driver > > [...] > > >>already there. > >> > >>Signed-off-by: Shawn Lin > >> > >>--- > > > >Knee jerk reaction is why does the provider code

Re: [PATCH v2] clk: check the actual phase if get_phase is provided

2016-02-25 Thread Shawn Lin
On 2016/2/26 7:14, Stephen Boyd wrote: On 02/18, Shawn Lin wrote: set_phase does sanity checking of degree and ask sub-driver [...] already there. Signed-off-by: Shawn Lin --- Knee jerk reaction is why does the provider code set a phase that isn't requested? Do we need some sort of clk_

Re: [PATCH v2] clk: check the actual phase if get_phase is provided

2016-02-25 Thread Stephen Boyd
On 02/18, Shawn Lin wrote: > set_phase does sanity checking of degree and ask sub-driver > to set the degree. If set_phase is limited to support the > degree what the caller need, sub-driver may select a > approximate value and return success state. In this case, it's > inappropriate to assign the

[PATCH v2] clk: check the actual phase if get_phase is provided

2016-02-17 Thread Shawn Lin
set_phase does sanity checking of degree and ask sub-driver to set the degree. If set_phase is limited to support the degree what the caller need, sub-driver may select a approximate value and return success state. In this case, it's inappropriate to assign the degree directly to clk->core->phase.