Re: [PATCH v2] chrome/platform: cros_ec_proto:: Add trace event to trace EC commands

2019-04-15 Thread kbuild test robot
Hi Raul, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1-rc5 next-20190412] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [PATCH v2] chrome/platform: cros_ec_proto:: Add trace event to trace EC commands

2019-04-15 Thread kbuild test robot
Hi Raul, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1-rc5 next-20190412] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [PATCH v2] chrome/platform: cros_ec_proto:: Add trace event to trace EC commands

2019-04-12 Thread Raul Rangel
On Fri, Apr 12, 2019 at 03:04:38PM -0400, Steven Rostedt wrote: > On Fri, 12 Apr 2019 12:49:44 -0600 > Raul E Rangel wrote: > > > +#define ec_cmds \ > > + {EC_CMD_PROTO_VERSION, "PROTO_VERSION"}, \ > > + {EC_CMD_HELLO, "HELLO"}, \ > > + {EC_CMD_GET_VERSION, "GET_VERSION"}, \ > > + {EC_CMD

Re: [PATCH v2] chrome/platform: cros_ec_proto:: Add trace event to trace EC commands

2019-04-12 Thread Steven Rostedt
On Fri, 12 Apr 2019 12:49:44 -0600 Raul E Rangel wrote: > +#define ec_cmds \ > + {EC_CMD_PROTO_VERSION, "PROTO_VERSION"}, \ > + {EC_CMD_HELLO, "HELLO"}, \ > + {EC_CMD_GET_VERSION, "GET_VERSION"}, \ > + {EC_CMD_READ_TEST, "READ_TEST"}, \ > + {EC_CMD_GET_BUILD_INFO, "GET_BUILD_I

[PATCH v2] chrome/platform: cros_ec_proto:: Add trace event to trace EC commands

2019-04-12 Thread Raul E Rangel
This is useful to see which EC commands are being executed and when. To enable: echo 'cros_ec:*' >> /sys/kernel/debug/tracing/set_event Example: /* cros_ec_cmd: version: 0, command: GET_VERSION */ /* cros_ec_cmd: version: 0, command: GET_PROTOCOL_INFO */ /* cros_ec_cmd: version: