Re: [PATCH v2] checkpatch.pl: Check for functions without a real prototype

2013-11-22 Thread Elena Ufimtseva
On Fri, Nov 22, 2013 at 5:45 PM, Joe Perches wrote: > On Fri, 2013-11-22 at 17:17 -0500, Elena Ufimtseva wrote: >> Based on Richard Weinberger patch https://lkml.org/lkml/2012/3/16/510 >> Functions like this one are evil: >> >> void foo() >> { >> ... >> } > [] >> - added white space in regul

Re: [PATCH v2] checkpatch.pl: Check for functions without a real prototype

2013-11-22 Thread Joe Perches
On Fri, 2013-11-22 at 17:17 -0500, Elena Ufimtseva wrote: > Based on Richard Weinberger patch https://lkml.org/lkml/2012/3/16/510 > Functions like this one are evil: > > void foo() > { > ... > } [] > - added white space in regular expression between (), based > on comments from Joe Perches.

[PATCH v2] checkpatch.pl: Check for functions without a real prototype

2013-11-22 Thread Elena Ufimtseva
Based on Richard Weinberger patch https://lkml.org/lkml/2012/3/16/510 Functions like this one are evil: void foo() { ... } Signed-off-by: Elena Ufimtseva --- Changes since v1: - added white space in regular expression between (), based on comments from Joe Perches. scripts/checkpatch.p