Re: [PATCH v2] checkpatch: use patch subject when reading from stdin

2020-05-05 Thread Geert Uytterhoeven
; > > > Your patch has style problems, please review. > > > > or: > > > > Your patch has no obvious style problems and is ready for submission. > > Showing the proposed "after patch" output would be helpful. It seems > that it will be > &g

Re: [kernel.org users] [PATCH v2] checkpatch: use patch subject when reading from stdin

2020-05-05 Thread Joe Perches
On Tue, 2020-05-05 at 22:40 +0200, Pali Rohár wrote: > Hello! > > On Tuesday 05 May 2020 12:57:37 Joe Perches wrote: > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > > index eac40f0abd56a9f4..3355358697d9e790 100755 > > > --- a/scripts/checkpatch.pl > > > +++ b/scripts/checkpat

Re: [kernel.org users] [PATCH v2] checkpatch: use patch subject when reading from stdin

2020-05-05 Thread Pali Rohár
Hello! On Tuesday 05 May 2020 12:57:37 Joe Perches wrote: > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index eac40f0abd56a9f4..3355358697d9e790 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -1057,6 +1057,10 @@ for my $filename (@ARGV) { > >

Re: [PATCH v2] checkpatch: use patch subject when reading from stdin

2020-05-05 Thread Joe Perches
On Tue, 2020-05-05 at 15:26 +0200, Geert Uytterhoeven wrote: > While "git am" can apply an mbox file containing multiple patches (e.g. > as created by b4[1], or a patch bundle downloaded from patchwork), > checkpatch does not have proper support for that. When operating on an > mbox, checkpatch wi

Re: [PATCH v2] checkpatch: use patch subject when reading from stdin

2020-05-05 Thread Andrew Morton
On Tue, 5 May 2020 15:26:13 +0200 Geert Uytterhoeven wrote: > While "git am" can apply an mbox file containing multiple patches (e.g. > as created by b4[1], or a patch bundle downloaded from patchwork), > checkpatch does not have proper support for that. When operating on an > mbox, checkpatch

[PATCH v2] checkpatch: use patch subject when reading from stdin

2020-05-05 Thread Geert Uytterhoeven
While "git am" can apply an mbox file containing multiple patches (e.g. as created by b4[1], or a patch bundle downloaded from patchwork), checkpatch does not have proper support for that. When operating on an mbox, checkpatch will merge all detected tags, and complain falsely about duplicates: