Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock

2017-11-15 Thread Prateek Sood
On 11/15/2017 10:35 PM, Tejun Heo wrote: > On Wed, Nov 15, 2017 at 11:37:42AM +0100, Peter Zijlstra wrote: >> On Wed, Nov 15, 2017 at 03:56:26PM +0530, Prateek Sood wrote: >>> Any improvement/suggestion for this patch? >> >> I would have done 2 patches, the first one solving the locking issue, >> t

Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock

2017-11-15 Thread Tejun Heo
On Wed, Nov 15, 2017 at 11:37:42AM +0100, Peter Zijlstra wrote: > On Wed, Nov 15, 2017 at 03:56:26PM +0530, Prateek Sood wrote: > > Any improvement/suggestion for this patch? > > I would have done 2 patches, the first one solving the locking issue, > the second removing the then redundant async re

Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock

2017-11-15 Thread Peter Zijlstra
On Wed, Nov 15, 2017 at 03:56:26PM +0530, Prateek Sood wrote: > Any improvement/suggestion for this patch? I would have done 2 patches, the first one solving the locking issue, the second removing the then redundant async rebuild stuff. Other than that this looks OK I suppose, but I was expecting

Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock

2017-11-15 Thread Prateek Sood
On 10/30/2017 12:46 PM, Prateek Sood wrote: > Remove circular dependency deadlock in a scenario where hotplug of CPU is > being done while there is updation in cgroup and cpuset triggered from > userspace. > > Process A => kthreadd => Process B => Process C => Process A > > Process A > cpu_subsys

Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock

2017-11-05 Thread Prateek Sood
On 10/30/2017 12:46 PM, Prateek Sood wrote: > Remove circular dependency deadlock in a scenario where hotplug of CPU is > being done while there is updation in cgroup and cpuset triggered from > userspace. > > Process A => kthreadd => Process B => Process C => Process A > > Process A > cpu_subsys

[PATCH v2] cgroup/cpuset: remove circular dependency deadlock

2017-10-30 Thread Prateek Sood
Remove circular dependency deadlock in a scenario where hotplug of CPU is being done while there is updation in cgroup and cpuset triggered from userspace. Process A => kthreadd => Process B => Process C => Process A Process A cpu_subsys_offline(); cpu_down(); _cpu_down(); percpu_down