Re: [PATCH v2] btrfs: add a check for sysfs_create_group

2019-01-08 Thread David Sterba
On Tue, Dec 25, 2018 at 11:37:44PM -0600, Kangjie Lu wrote: > In case sysfs_create_group fails, let's check its return value and > issues an error message. It's in a function that's not currently used and the sysfs code needs to be reworked. The return code should be passed to the caller, printing

Re: [PATCH v2] btrfs: add a check for sysfs_create_group

2018-12-25 Thread Qu Wenruo
On 2018/12/26 下午1:37, Kangjie Lu wrote: > In case sysfs_create_group fails, let's check its return value and > issues an error message. > > Signed-off-by: Kangjie Lu > --- > fs/btrfs/sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c > index

Re: [PATCH v2] btrfs: add a check for sysfs_create_group

2018-12-25 Thread Su Yue
On 12/26/18 1:37 PM, Kangjie Lu wrote: In case sysfs_create_group fails, let's check its return value and issues an error message. Signed-off-by: Kangjie Lu --- fs/btrfs/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 3717c864ba23..2

[PATCH v2] btrfs: add a check for sysfs_create_group

2018-12-25 Thread Kangjie Lu
In case sysfs_create_group fails, let's check its return value and issues an error message. Signed-off-by: Kangjie Lu --- fs/btrfs/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 3717c864ba23..24ef416e700b 100644 --- a/fs/btrfs/sysfs.c +++