RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-30 Thread Chen, Alvin
> > The EHCI packet buffer in/out threshold is programmable for Intel > > Quark X1000 USB host controller, and the default value is 0x20 dwords. > > The in/out threshold can be programmed to 0x80 dwords, but only when > > isochronous/interrupt transactions are not initiated by the USB host > > cont

Re: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread Alan Stern
On Fri, 27 Jun 2014, Chen, Alvin wrote: > From: Bryan O'Donoghue > > The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000 > USB host > controller, and the default value is 0x20 dwords. The in/out threshold can be > programmed > to 0x80 dwords, but only when isochronous

RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread Chen, Alvin
> -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Friday, June 27, 2014 4:08 PM > ... > > /* The maximal threshold value is 0x80, which means 512 bytes */ > > #define EHCI_THRESHOLD_512BYTES 0x80 > > #define EHCI_THRESHOLD_508BYTES

RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread David Laight
From: Jingoo Han ... > /* The maximal threshold value is 0x80, which means 512 bytes */ > #define EHCI_THRESHOLD_512BYTES 0x80 > #define EHCI_THRESHOLD_508BYTES 0x79 It would be better to define these using expressions. So: #define EHCI_THRESHOLD_512BYTES (512u

RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-27 Thread Chen, Alvin
> > > The EHCI packet buffer in/out threshold is programmable for Intel > > > Quark X1000 USB host controller, and the default value is 0x20 > > > dwords. The in/out threshold can be programmed to 0x80 dwords, but > > > only when isochronous/interrupt transactions are not initiated by > > > the US

Re: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-26 Thread Jingoo Han
On Friday, June 27, 2014 1:33 PM, Jingoo Han wrote: > On Friday, June 27, 2014 8:25 PM, Alvin Chen wrote: > > > > From: Bryan O'Donoghue > > > > The EHCI packet buffer in/out threshold is programmable for Intel Quark > > X1000 USB host > > controller, and the default value is 0x20 dwords. The in/

Re: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-26 Thread Jingoo Han
On Friday, June 27, 2014 8:25 PM, Alvin Chen wrote: > > From: Bryan O'Donoghue > > The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000 > USB host > controller, and the default value is 0x20 dwords. The in/out threshold can be > programmed > to 0x80 dwords, but only wh

[PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-26 Thread Chen, Alvin
From: Bryan O'Donoghue The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000 USB host controller, and the default value is 0x20 dwords. The in/out threshold can be programmed to 0x80 dwords, but only when isochronous/interrupt transactions are not initiated by the USB h