Re: [PATCH v2] RDMA/rtrs: client: Fix function return on success

2020-05-19 Thread Jason Gunthorpe
On Tue, May 19, 2020 at 11:36:12AM -0500, Gustavo A. R. Silva wrote: > Remove the if-statement and return the value contained in _err_, > unconditionally. > > Addresses-Coverity-ID: 1493753 ("Identical code for different branches") > Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality") >

Re: [PATCH v2] RDMA/rtrs: client: Fix function return on success

2020-05-19 Thread Bart Van Assche
On 2020-05-19 09:36, Gustavo A. R. Silva wrote: > Remove the if-statement and return the value contained in _err_, > unconditionally. Thanks Gustavo! Reviewed-by: Bart Van Assche

[PATCH v2] RDMA/rtrs: client: Fix function return on success

2020-05-19 Thread Gustavo A. R. Silva
Remove the if-statement and return the value contained in _err_, unconditionally. Addresses-Coverity-ID: 1493753 ("Identical code for different branches") Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality") Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Return err, uncondition