Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-12 Thread Rafael J. Wysocki
On Friday, January 12, 2018 2:46:12 PM CET Ulf Hansson wrote: > On 12 January 2018 at 02:55, Rafael J. Wysocki wrote: > > On Tue, Jan 9, 2018 at 7:08 AM, Ulf Hansson wrote: > >> On 3 January 2018 at 12:06, Rafael J. Wysocki wrote: > >>> From: Rafael J. Wysocki > >>> > >>> One of the limitations

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-12 Thread Ulf Hansson
On 12 January 2018 at 02:55, Rafael J. Wysocki wrote: > On Tue, Jan 9, 2018 at 7:08 AM, Ulf Hansson wrote: >> On 3 January 2018 at 12:06, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> One of the limitations of pm_runtime_force_suspend/resume() is that >>> if a parent driver wants

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-12 Thread Rafael J. Wysocki
On Friday, January 12, 2018 12:26:56 PM CET Geert Uytterhoeven wrote: > Hi Rafael, > > On Tue, Jan 9, 2018 at 5:28 PM, Rafael J. Wysocki wrote: > > On Tuesday, January 9, 2018 5:03:18 PM CET Rafael J. Wysocki wrote: > >> On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven > >> wrote: > >> > On T

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-12 Thread Geert Uytterhoeven
Hi Rafael, On Tue, Jan 9, 2018 at 5:28 PM, Rafael J. Wysocki wrote: > On Tuesday, January 9, 2018 5:03:18 PM CET Rafael J. Wysocki wrote: >> On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven >> wrote: >> > On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki >> > wrote: >> >> On Tue, Jan 9, 201

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-12 Thread Geert Uytterhoeven
Hi Rafael, On Tue, Jan 9, 2018 at 5:25 PM, Rafael J. Wysocki wrote: > On Tuesday, January 9, 2018 4:00:35 PM CET Rafael J. Wysocki wrote: >> On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven >> wrote: >> > On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki >> > wrote: >> >> From: Rafael J. W

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-11 Thread Rafael J. Wysocki
On Tue, Jan 9, 2018 at 7:08 AM, Ulf Hansson wrote: > On 3 January 2018 at 12:06, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> One of the limitations of pm_runtime_force_suspend/resume() is that >> if a parent driver wants to use these functions, all of its child >> drivers have to d

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-11 Thread Rafael J. Wysocki
On Thu, Jan 11, 2018 at 1:32 PM, Ulf Hansson wrote: [cut] >>> >>> The point is, we can go for this solution, but is it good enough? >> >> I would like to treat it as a step away from what is there today, >> retaining some of the existing functionality. >> >> From a quick look at the existing use

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-11 Thread Ulf Hansson
[...] >>> Index: linux-pm/drivers/base/power/domain.c >>> === >>> --- linux-pm.orig/drivers/base/power/domain.c >>> +++ linux-pm/drivers/base/power/domain.c >>> @@ -1048,8 +1048,9 @@ static int genpd_finish_suspend(struct d >>>

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-10 Thread Rafael J. Wysocki
On Wed, Jan 10, 2018 at 10:26 AM, Ulf Hansson wrote: > On 9 January 2018 at 17:28, Rafael J. Wysocki wrote: >> On Tuesday, January 9, 2018 5:03:18 PM CET Rafael J. Wysocki wrote: >>> On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven >>> wrote: [cut] >>> That's because of the pm_runtime_force

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-10 Thread Ulf Hansson
On 9 January 2018 at 17:28, Rafael J. Wysocki wrote: > On Tuesday, January 9, 2018 5:03:18 PM CET Rafael J. Wysocki wrote: >> On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven >> wrote: >> > Hi Rafael, >> > >> > CC usb >> > >> > On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki >> > wrote: >>

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tue, Jan 9, 2018 at 7:46 PM, Rafael J. Wysocki wrote: > On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven > wrote: >> Hi Rafael, >> >> On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki >> wrote: >>> From: Rafael J. Wysocki >>> [cut] >>> >>> Signed-off-by: Rafael J. Wysocki >> >> This

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven wrote: > Hi Rafael, > > On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> One of the limitations of pm_runtime_force_suspend/resume() is that >> if a parent driver wants to use these functions, all of its

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tuesday, January 9, 2018 5:03:18 PM CET Rafael J. Wysocki wrote: > On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven > wrote: > > Hi Rafael, > > > > CC usb > > > > On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki wrote: > >> On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven > >> wrote: >

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
sabled? > > Probably. > > Likely a device that wasn't resumed before resumes now and that causes > the issue to appear. > > I'm wondering if adding the ignore_children check to the patch helps. > If not, there clearly is a resume ordering issue that is pape

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven wrote: > Hi Rafael, > > CC usb > > On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki wrote: >> On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven >> wrote: >>> On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki >>> wrote: From: Rafael J.

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Geert Uytterhoeven
Hi Rafael, CC usb On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki wrote: > On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven > wrote: >> On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki >> wrote: >>> From: Rafael J. Wysocki >>> >>> One of the limitations of pm_runtime_force_suspend/res

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven wrote: > Hi Rafael, > > On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> One of the limitations of pm_runtime_force_suspend/resume() is that >> if a parent driver wants to use these functions, all of its

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Geert Uytterhoeven
Hi Ulf, On Tue, Jan 9, 2018 at 3:27 PM, Ulf Hansson wrote: > On 9 January 2018 at 14:37, Geert Uytterhoeven wrote: >> On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki >> wrote: >>> From: Rafael J. Wysocki >>> One of the limitations of pm_runtime_force_suspend/resume() is that >>> if a paren

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Ulf Hansson
On 9 January 2018 at 14:37, Geert Uytterhoeven wrote: > Hi Rafael, > > On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> One of the limitations of pm_runtime_force_suspend/resume() is that >> if a parent driver wants to use these functions, all of its chi

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Ulf Hansson
[...] >> > +++ linux-pm/drivers/base/power/runtime.c >> > @@ -1613,17 +1613,28 @@ void pm_runtime_drop_link(struct device >> > spin_unlock_irq(&dev->power.lock); >> > } >> > >> > +static bool pm_runtime_need_not_resume(struct device *dev) >> > +{ >> > + return atomic_read(&dev->powe

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Geert Uytterhoeven
Hi Rafael, On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > One of the limitations of pm_runtime_force_suspend/resume() is that > if a parent driver wants to use these functions, all of its child > drivers have to do that too because of the parent usage cou

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tuesday, January 9, 2018 7:08:21 AM CET Ulf Hansson wrote: > On 3 January 2018 at 12:06, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > One of the limitations of pm_runtime_force_suspend/resume() is that > > if a parent driver wants to use these functions, all of its child > > dr

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-08 Thread Ulf Hansson
On 3 January 2018 at 12:06, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > One of the limitations of pm_runtime_force_suspend/resume() is that > if a parent driver wants to use these functions, all of its child > drivers have to do that too because of the parent usage counter > manipulati

[PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-03 Thread Rafael J. Wysocki
From: Rafael J. Wysocki One of the limitations of pm_runtime_force_suspend/resume() is that if a parent driver wants to use these functions, all of its child drivers have to do that too because of the parent usage counter manipulations necessary to get the correct state of the parent during syste