Re: [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

2019-02-11 Thread Kishon Vijay Abraham I
Hi Gustavo, On 11/02/19 2:45 PM, Gustavo Pimentel wrote: > On 11/02/2019 05:48, Kishon Vijay Abraham I wrote: >> Hi Lorenzo, >> >> On 08/02/19 5:50 PM, Lorenzo Pieralisi wrote: >>> On Thu, Dec 06, 2018 at 08:52:25PM +0800, Wen Yang wrote: kmemdup has implemented the function that kmalloc() +

Re: [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

2019-02-11 Thread Gustavo Pimentel
On 11/02/2019 05:48, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On 08/02/19 5:50 PM, Lorenzo Pieralisi wrote: >> On Thu, Dec 06, 2018 at 08:52:25PM +0800, Wen Yang wrote: >>> kmemdup has implemented the function that kmalloc() + memcpy(). >>> We prefer to kmemdup rather than code opened imple

Re: [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

2019-02-10 Thread Kishon Vijay Abraham I
Hi Lorenzo, On 08/02/19 5:50 PM, Lorenzo Pieralisi wrote: > On Thu, Dec 06, 2018 at 08:52:25PM +0800, Wen Yang wrote: >> kmemdup has implemented the function that kmalloc() + memcpy(). >> We prefer to kmemdup rather than code opened implementation. >> >> This issue was detected with the help of co

Re: [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

2019-02-08 Thread Lorenzo Pieralisi
On Thu, Dec 06, 2018 at 08:52:25PM +0800, Wen Yang wrote: > kmemdup has implemented the function that kmalloc() + memcpy(). > We prefer to kmemdup rather than code opened implementation. > > This issue was detected with the help of coccinelle. > > Signed-off-by: Wen Yang > CC: Kishon Vijay Abrah

[PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function

2018-12-06 Thread Wen Yang
kmemdup has implemented the function that kmalloc() + memcpy(). We prefer to kmemdup rather than code opened implementation. This issue was detected with the help of coccinelle. Signed-off-by: Wen Yang CC: Kishon Vijay Abraham I CC: Lorenzo Pieralisi CC: Bjorn Helgaas CC: Gustavo Pimentel CC