Re: [PATCH v2] PCI: brcmstb: Add missing if statement and error path

2020-09-23 Thread Lorenzo Pieralisi
On Mon, Sep 21, 2020 at 10:16:24PM +0100, Alex Dewar wrote: > brcm_pcie_resume() contains a return statement that was presumably > intended to have an "if (ret)" in front of it, otherwise the function > returns prematurely. Fix this. > > Additionally, redisable the clock on the error path. > > I

Re: [PATCH v2] PCI: brcmstb: Add missing if statement and error path

2020-09-21 Thread Florian Fainelli
On 9/21/20 2:16 PM, Alex Dewar wrote: > brcm_pcie_resume() contains a return statement that was presumably > intended to have an "if (ret)" in front of it, otherwise the function > returns prematurely. Fix this. > > Additionally, redisable the clock on the error path. > > I don't know if this cod

[PATCH v2] PCI: brcmstb: Add missing if statement and error path

2020-09-21 Thread Alex Dewar
brcm_pcie_resume() contains a return statement that was presumably intended to have an "if (ret)" in front of it, otherwise the function returns prematurely. Fix this. Additionally, redisable the clock on the error path. I don't know if this code was tested or not, but I assume that this bug mean