Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Alex G.
On 06/01/2018 10:10 AM, Sinan Kaya wrote: > On 6/1/2018 11:06 AM, Alex G. wrote: >> On 06/01/2018 10:03 AM, Sinan Kaya wrote: >>> On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: + /* Multi-function PCIe share the same link/status. */ + if (PCI_FUNC(dev->devfn) != 0) + re

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Alex G.
On 06/01/2018 10:12 AM, Andy Shevchenko wrote: > On Fri, Jun 1, 2018 at 6:01 PM, Alexandru Gagniuc > wrote: >> PCIe downtraining happens when both the device and PCIe port are >> capable of a larger bus width or higher speed than negotiated. >> Downtraining might be indicative of other problems i

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Andy Shevchenko
On Fri, Jun 1, 2018 at 6:01 PM, Alexandru Gagniuc wrote: > PCIe downtraining happens when both the device and PCIe port are > capable of a larger bus width or higher speed than negotiated. > Downtraining might be indicative of other problems in the system, and > identifying this from userspace is

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Sinan Kaya
On 6/1/2018 11:06 AM, Alex G. wrote: > On 06/01/2018 10:03 AM, Sinan Kaya wrote: >> On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: >>> + /* Multi-function PCIe share the same link/status. */ >>> + if (PCI_FUNC(dev->devfn) != 0) >>> + return; >> >> How about virtual functions? > > I h

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Alex G.
On 06/01/2018 10:03 AM, Sinan Kaya wrote: > On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: >> +/* Multi-function PCIe share the same link/status. */ >> +if (PCI_FUNC(dev->devfn) != 0) >> +return; > > How about virtual functions? I have almost no clue about those. Is your conce

Re: [PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Sinan Kaya
On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: > + /* Multi-function PCIe share the same link/status. */ > + if (PCI_FUNC(dev->devfn) != 0) > + return; How about virtual functions? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies,

[PATCH v2] PCI: Check for PCIe downtraining conditions

2018-06-01 Thread Alexandru Gagniuc
PCIe downtraining happens when both the device and PCIe port are capable of a larger bus width or higher speed than negotiated. Downtraining might be indicative of other problems in the system, and identifying this from userspace is neither intuitive, nor straigh forward. The easiest way to detect