Re: [PATCH v2] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-06 Thread Emil Goode
Hello Maciej, I didn't know it was possible to go beyond commit 1da177e, thank you for the info. Best regards, Emil On Sun, Jul 06, 2014 at 12:16:38PM +0100, Maciej W. Rozycki wrote: > On Sun, 6 Jul 2014, Emil Goode wrote: > > > > > diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c

Re: [PATCH v2] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-06 Thread Maciej W. Rozycki
On Sun, 6 Jul 2014, Emil Goode wrote: > > > diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c > > > index d657493..6546758 100644 > > > --- a/arch/mips/mm/tlb-r3k.c > > > +++ b/arch/mips/mm/tlb-r3k.c > > > @@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma, > > >

Re: [PATCH v2] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-05 Thread Emil Goode
Hello, On Sat, Jul 05, 2014 at 09:10:44PM +0200, Jonas Gorski wrote: > On Sat, Jul 5, 2014 at 8:26 PM, Emil Goode wrote: > > We check that the struct vm_area_struct pointer vma is NULL and then > > dereference it a few lines below. The intent must have been to make sure > > that vma is not NULL a

Re: [PATCH v2] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-05 Thread Jonas Gorski
On Sat, Jul 5, 2014 at 8:26 PM, Emil Goode wrote: > We check that the struct vm_area_struct pointer vma is NULL and then > dereference it a few lines below. The intent must have been to make sure > that vma is not NULL and then to check the value from cpu_context() for > the condition to be true.

[PATCH v2] MIPS: Fix incorrect NULL check in local_flush_tlb_page()

2014-07-05 Thread Emil Goode
We check that the struct vm_area_struct pointer vma is NULL and then dereference it a few lines below. The intent must have been to make sure that vma is not NULL and then to check the value from cpu_context() for the condition to be true. Signed-off-by: Emil Goode --- v2: Updated the commit mes