Re: [PATCH v2] KVM: x86: fix access memslots w/o hold srcu read lock

2014-10-30 Thread Chen, Tiejun
On 2014/10/31 14:26, Wanpeng Li wrote: The srcu read lock must be held while accessing memslots (e.g. when using gfn_to_* functions), however, commit c24ae0dcd3e8 ("kvm: x86: Unpin and remove kvm_arch->apic_access_page") call gfn_to_page() in kvm_vcpu_reload_apic_access_page() w/o hold it in vmx_

Re: [PATCH v2] KVM: x86: fix access memslots w/o hold srcu read lock

2014-10-30 Thread Wanpeng Li
On Fri, Oct 31, 2014 at 02:26:59PM +0800, Wanpeng Li wrote: >The srcu read lock must be held while accessing memslots (e.g. >when using gfn_to_* functions), however, commit c24ae0dcd3e8 >("kvm: x86: Unpin and remove kvm_arch->apic_access_page") call >gfn_to_page() in kvm_vcpu_reload_apic_access_pag

[PATCH v2] KVM: x86: fix access memslots w/o hold srcu read lock

2014-10-30 Thread Wanpeng Li
The srcu read lock must be held while accessing memslots (e.g. when using gfn_to_* functions), however, commit c24ae0dcd3e8 ("kvm: x86: Unpin and remove kvm_arch->apic_access_page") call gfn_to_page() in kvm_vcpu_reload_apic_access_page() w/o hold it in vmx_vcpu_reset() path which leads to suspici