Re: [PATCH v2] KVM: X86: Fix CR3 reserve bits

2018-05-14 Thread Paolo Bonzini
On 13/05/2018 11:24, Wanpeng Li wrote: > From: Wanpeng Li > > MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > It should be checked when PCIDE bit is not set, however commit > 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on > its physical address width")' re

Re: [PATCH v2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Junaid Shahid
On 05/13/2018 02:24 AM, Wanpeng Li wrote: > From: Wanpeng Li > > MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > It should be checked when PCIDE bit is not set, however commit > 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on > its physical address width")'

Re: [PATCH v2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > From: Wanpeng Li > > MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > It should be checked when PCIDE bit is not set, however commit > 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on > its physical address width")' remove

[PATCH v2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
From: Wanpeng Li MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. It should be checked when PCIDE bit is not set, however commit 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on its physical address width")' removes the bit 63 checking unconditionally. This pa