Re: [PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread Oliver Neukum
On Thu, 2013-10-24 at 18:26 +0900, hyunhee.kim wrote: > Hi, > > Thanks for your review. > I resent patch v3 after removing wrong wrapping. > > I made one toggle function because enable/disable functions have redundant > codes and another reviewer suggested it. > Is it better to separate it into

RE: [PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread hyunhee.kim
dation.org; kyungmin.p...@samsung.com; 'Aristeu Sergio Rozanski Filho' Subject: Re: [PATCH v2] Input: add regulator haptic driver On Thu, 2013-10-24 at 15:35 +0900, hyunhee.kim wrote: Hi, first of all your mail client mangled the patch. > +static void regulator_haptic_toggle(struct regulat

Re: [PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread Oliver Neukum
On Thu, 2013-10-24 at 15:35 +0900, hyunhee.kim wrote: Hi, first of all your mail client mangled the patch. > +static void regulator_haptic_toggle(struct regulator_haptic *haptic, bool > enable) > +{ > + int ret; > + > + mutex_lock(&haptic->mutex); > + if (enable && !haptic->enabled)

[PATCH v2] Input: add regulator haptic driver

2013-10-24 Thread hyunhee.kim
From: Hyunhee Kim Date: Wed, 9 Oct 2013 16:21:36 +0900 Subject: [PATCH] Input: add regulator haptic driver Signed-off-by: Hyunhee Kim Signed-off-by: Kyungmin Park Acked-by: Aristeu Rozanski --- drivers/input/misc/Kconfig| 10 ++ drivers/input/misc/Makefile |1 + d

[PATCH v2] Input: add regulator haptic driver

2013-10-23 Thread hyunhee.kim
From: Hyunhee Kim Date: Wed, 9 Oct 2013 16:21:36 +0900 Subject: [PATCH] tizenw: add regulator haptic driver Signed-off-by: Hyunhee Kim Signed-off-by: Kyungmin Park Acked-by: Aristeu Rozanski --- drivers/input/misc/Kconfig| 10 ++ drivers/input/misc/Makefile |1 +