Re: [PATCH v2] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-29 Thread Nick Crews
Your reasonings sound good. One or two responses in line, otherwise the version you just sent looks good. On Fri, Mar 29, 2019 at 12:59 PM Rushikesh S Kadam wrote: > > Hi Nick > Please see my comments inline below, > > On Thu, Mar 28, 2019 at 11:02:52PM -0700, Nick Crews wrote: > > This is so clo

Re: [PATCH v2] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-29 Thread Rushikesh S Kadam
Hi Nick Please see my comments inline below, On Thu, Mar 28, 2019 at 11:02:52PM -0700, Nick Crews wrote: > This is so close! There are just one or two tiny things. > > On Thu, Mar 28, 2019 at 1:20 PM Rushikesh S Kadam > wrote: > > +/** > > + * loader_cl_send()Send message from host to firmw

Re: [PATCH v2] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-28 Thread Nick Crews
This is so close! There are just one or two tiny things. On Thu, Mar 28, 2019 at 1:20 PM Rushikesh S Kadam wrote: > > This driver adds support for loading Intel Integrated > Sensor Hub (ISH) firmware from host file system to ISH > SRAM and start execution. > > At power-on, the ISH subsystem shall

[PATCH v2] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-28 Thread Rushikesh S Kadam
This driver adds support for loading Intel Integrated Sensor Hub (ISH) firmware from host file system to ISH SRAM and start execution. At power-on, the ISH subsystem shall boot to an interim Shim loader-firmware, which shall expose an ISHTP loader device. The driver implements an ISHTP client tha