Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-09-16 Thread Seunghun Han
> Eessentially what you want to do is to detach and backup the original > NVS resources and put them back to the list with insert_resource() when > tpm_crb is removed. At least I think this is what should be done but you > should CC your patch also to the ACPI list for feedback. > > /Jarkko Yes, y

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-09-16 Thread Jarkko Sakkinen
On Mon, Sep 16, 2019 at 02:29:01PM +0900, Seunghun Han wrote: > > > > On Fri, Sep 13, 2019 at 03:00:06PM +0100, Jarkko Sakkinen wrote: > > > On Wed, Sep 11, 2019 at 02:17:48PM +0900, Seunghun Han wrote: > > > > Vanya, > > > > I also made a patch series to solve AMD's fTPM. My patch link is here, >

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-09-15 Thread Seunghun Han
> > On Fri, Sep 13, 2019 at 03:00:06PM +0100, Jarkko Sakkinen wrote: > > On Wed, Sep 11, 2019 at 02:17:48PM +0900, Seunghun Han wrote: > > > Vanya, > > > I also made a patch series to solve AMD's fTPM. My patch link is here, > > > https://lkml.org/lkml/2019/9/9/132 . > > > > > > The maintainer, Jar

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-09-13 Thread Jarkko Sakkinen
On Fri, Sep 13, 2019 at 03:00:06PM +0100, Jarkko Sakkinen wrote: > On Wed, Sep 11, 2019 at 02:17:48PM +0900, Seunghun Han wrote: > > Vanya, > > I also made a patch series to solve AMD's fTPM. My patch link is here, > > https://lkml.org/lkml/2019/9/9/132 . > > > > The maintainer, Jarkko, wanted me

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-09-13 Thread Jarkko Sakkinen
On Wed, Sep 11, 2019 at 02:17:48PM +0900, Seunghun Han wrote: > Vanya, > I also made a patch series to solve AMD's fTPM. My patch link is here, > https://lkml.org/lkml/2019/9/9/132 . > > The maintainer, Jarkko, wanted me to remark on your patch, so I would > like to cooperate with you. > > Your p

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-09-10 Thread Seunghun Han
> > And why is this allocating memory inside the acpi table walker? It > > seems to me like the memory should be allocated once the mapping is > > made. > > > > Yes, this looks bad. Letting the walker build the list and then using > it is, probably, a better idea. > > > Maybe all the mappings shoul

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-08-15 Thread Jarkko Sakkinen
On Tue, Aug 13, 2019 at 01:42:42AM +0300, Vanya Lazeev wrote: > fTPM on Zen+ not only needs multiple mappings, it can also return > inconsistent with ACPI values for range sizes (as for me and > mikajhe from the bug thread), so results of crb_containing_resource > are also used to fix the inconsist

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-08-12 Thread Vanya Lazeev
On Mon, Aug 12, 2019 at 10:10:03AM -0300, Jason Gunthorpe wrote: > On Sun, Aug 11, 2019 at 09:52:18PM +0300, ivan.laz...@gmail.com wrote: > > From: Vanya Lazeev > > > > The patch is an attempt to make fTPM on AMD Zen CPUs work. > > Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657 > >

Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-08-12 Thread Jason Gunthorpe
On Sun, Aug 11, 2019 at 09:52:18PM +0300, ivan.laz...@gmail.com wrote: > From: Vanya Lazeev > > The patch is an attempt to make fTPM on AMD Zen CPUs work. > Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657 > > The problem seems to be that tpm_crb driver doesn't expect tpm command > a

[PATCH v2] Fix fTPM on AMD Zen+ CPUs

2019-08-11 Thread ivan . lazeev
From: Vanya Lazeev The patch is an attempt to make fTPM on AMD Zen CPUs work. Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657 The problem seems to be that tpm_crb driver doesn't expect tpm command and response memory regions to belong to different ACPI resources. Tested on Asrock I