Re: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

2018-08-30 Thread Kani, Toshi
On Thu, 2018-08-30 at 18:37 +, Fan Wu wrote: > For platforms whose firmwares provide valid module handles > (SMBIOS type 17) in error records, this patch uses the module > handles to locate corresponding DIMMs and enables per-DIMM > error counter update. > > Signed-off-by: Fan Wu Tested on a

RE: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

2018-08-30 Thread wufan
Hi Tyler, > > +static int get_dimm_smbios_index(u16 handle) { > > + struct mem_ctl_info *mci; > > + int i; > > + > > + mci = ghes_pvt->mci; > > + > > Minor nit: you could define and set mci in the same line to save some space > here. > > Otherwise this patch looks good to me.

Re: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

2018-08-30 Thread Tyler Baicar
Hi Fan, On Thu, Aug 30, 2018 at 2:37 PM, Fan Wu wrote: > For platforms whose firmwares provide valid module handles > (SMBIOS type 17) in error records, this patch uses the module > handles to locate corresponding DIMMs and enables per-DIMM > error counter update. > > Signed-off-by: Fan Wu > di

[PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

2018-08-30 Thread Fan Wu
For platforms whose firmwares provide valid module handles (SMBIOS type 17) in error records, this patch uses the module handles to locate corresponding DIMMs and enables per-DIMM error counter update. Signed-off-by: Fan Wu --- Changes from v1: * Changed the new function name to get_dimm_smbios