Re: [PATCH v2] Bugfix for handling of shadow doorbell buffer.

2018-08-20 Thread Michal Wnukowski
Thanks for applying and improving the comments. All still makes sense. I will forward this patch to sta...@vger.kernel.org once it get merged into Linus’ tree. On 08/17/2018 12:07 AM, Christoph Hellwig wrote: > I've applied this with some major updates to the subject, changelog > and the comment i

Re: [PATCH v2] Bugfix for handling of shadow doorbell buffer.

2018-08-17 Thread Christoph Hellwig
I've applied this with some major updates to the subject, changelog and the comment in the code. Please double check it all still makes sense.

Re: [PATCH v2] Bugfix for handling of shadow doorbell buffer.

2018-08-16 Thread Sagi Grimberg
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 17a0190bd88f..4452f8553301 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -306,6 +306,14 @@ static bool nvme_dbbuf_update_and_check_event(u16 value, u32 *dbbuf_db, old_value = *dbbuf_db;

Re: [PATCH v2] Bugfix for handling of shadow doorbell buffer.

2018-08-16 Thread Keith Busch
On Wed, Aug 15, 2018 at 03:51:57PM -0700, Michal Wnukowski wrote: > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index 17a0190bd88f..4452f8553301 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -306,6 +306,14 @@ static bool nvme_dbbuf_update_and_check

[PATCH v2] Bugfix for handling of shadow doorbell buffer.

2018-08-15 Thread Michal Wnukowski
This patch adds full memory barrier into nvme_dbbuf_update_and_check_event function to ensure that the shadow doorbell is written before reading EventIdx from memory. This is a critical bugfix for initial patch that added support for shadow doorbell into NVMe driver (f9f38e33389c019ec880f6825119c94