Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-06 Thread Yu-Hsuan Hsu
Yu-Hsuan Hsu 於 2020年7月4日 週六 下午7:34寫道： > > Guenter Roeck 於 2020年7月4日 週六 上午3:28寫道： > > > > On Fri, Jul 3, 2020 at 12:11 PM Yu-Hsuan Hsu wrote: > > > > > > Guenter Roeck 於 2020年7月3日 週五 下午11:58寫道： > > > > > > > > On Fri, Jul 3, 2020 at 3:56 AM Enric Balletbo i Serra > > > > wrote: > > > > > > > >

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-04 Thread Yu-Hsuan Hsu
Guenter Roeck 於 2020年7月4日 週六 上午3:28寫道： > > On Fri, Jul 3, 2020 at 12:11 PM Yu-Hsuan Hsu wrote: > > > > Guenter Roeck 於 2020年7月3日 週五 下午11:58寫道： > > > > > > On Fri, Jul 3, 2020 at 3:56 AM Enric Balletbo i Serra > > > wrote: > > > > > > > > Hi Yu-Hsuan, > > > > > > > > On 3/7/20 11:40, Yu-Hsuan Hs

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Guenter Roeck
On Fri, Jul 3, 2020 at 12:11 PM Yu-Hsuan Hsu wrote: > > Guenter Roeck 於 2020年7月3日 週五 下午11:58寫道： > > > > On Fri, Jul 3, 2020 at 3:56 AM Enric Balletbo i Serra > > wrote: > > > > > > Hi Yu-Hsuan, > > > > > > On 3/7/20 11:40, Yu-Hsuan Hsu wrote: > > > > Enric Balletbo i Serra 於 2020年7月3日 週五 > > >

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Yu-Hsuan Hsu
Guenter Roeck 於 2020年7月3日 週五 下午11:58寫道： > > On Fri, Jul 3, 2020 at 3:56 AM Enric Balletbo i Serra > wrote: > > > > Hi Yu-Hsuan, > > > > On 3/7/20 11:40, Yu-Hsuan Hsu wrote: > > > Enric Balletbo i Serra 於 2020年7月3日 週五 > > > 下午5:19寫道： > > >> > > >> Hi Yu-Hsuan, > > >> > > >> On 3/7/20 10:48, Yu-H

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Guenter Roeck
On Fri, Jul 3, 2020 at 3:56 AM Enric Balletbo i Serra wrote: > > Hi Yu-Hsuan, > > On 3/7/20 11:40, Yu-Hsuan Hsu wrote: > > Enric Balletbo i Serra 於 2020年7月3日 週五 > > 下午5:19寫道： > >> > >> Hi Yu-Hsuan, > >> > >> On 3/7/20 10:48, Yu-Hsuan Hsu wrote: > >>> Enric Balletbo i Serra 於 2020年7月3日 週五 > >>>

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Enric Balletbo i Serra
Hi Yu-Hsuan, On 3/7/20 11:40, Yu-Hsuan Hsu wrote: > Enric Balletbo i Serra 於 2020年7月3日 週五 下午5:19寫道： >> >> Hi Yu-Hsuan, >> >> On 3/7/20 10:48, Yu-Hsuan Hsu wrote: >>> Enric Balletbo i Serra 於 2020年7月3日 週五 >>> 下午4:38寫道： Hi Yu-Hsuan, Thank you for your patch On 3/7/20

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Yu-Hsuan Hsu
Enric Balletbo i Serra 於 2020年7月3日 週五 下午5:19寫道： > > Hi Yu-Hsuan, > > On 3/7/20 10:48, Yu-Hsuan Hsu wrote: > > Enric Balletbo i Serra 於 2020年7月3日 週五 > > 下午4:38寫道： > >> > >> Hi Yu-Hsuan, > >> > >> Thank you for your patch > >> > >> On 3/7/20 9:19, Yu-Hsuan Hsu wrote: > >>> Log results of failed EC

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Enric Balletbo i Serra
Hi Yu-Hsuan, On 3/7/20 10:48, Yu-Hsuan Hsu wrote: > Enric Balletbo i Serra 於 2020年7月3日 週五 下午4:38寫道： >> >> Hi Yu-Hsuan, >> >> Thank you for your patch >> >> On 3/7/20 9:19, Yu-Hsuan Hsu wrote: >>> Log results of failed EC commands to identify a problem more easily. >>> >>> Replace cros_ec_cmd_xfer

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Yu-Hsuan Hsu
Enric Balletbo i Serra 於 2020年7月3日 週五 下午4:38寫道： > > Hi Yu-Hsuan, > > Thank you for your patch > > On 3/7/20 9:19, Yu-Hsuan Hsu wrote: > > Log results of failed EC commands to identify a problem more easily. > > > > Replace cros_ec_cmd_xfer_status with cros_ec_cmd_xfer because the result > > has al

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Enric Balletbo i Serra
Hi Yu-Hsuan, Thank you for your patch On 3/7/20 9:19, Yu-Hsuan Hsu wrote: > Log results of failed EC commands to identify a problem more easily. > > Replace cros_ec_cmd_xfer_status with cros_ec_cmd_xfer because the result > has already been checked in this function. The wrapper is not needed. >

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Yu-Hsuan Hsu
Tzung-Bi Shih 於 2020年7月3日 週五 下午3:32寫道： > > On Fri, Jul 3, 2020 at 3:19 PM Yu-Hsuan Hsu wrote: > > Log results of failed EC commands to identify a problem more easily. > > > > Replace cros_ec_cmd_xfer_status with cros_ec_cmd_xfer because the result > > has already been checked in this function. Th

Re: [PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Tzung-Bi Shih
On Fri, Jul 3, 2020 at 3:19 PM Yu-Hsuan Hsu wrote: > Log results of failed EC commands to identify a problem more easily. > > Replace cros_ec_cmd_xfer_status with cros_ec_cmd_xfer because the result > has already been checked in this function. The wrapper is not needed. Alternatively, you can sti

[PATCH v2] ASoC: cros_ec_codec: Log results when EC commands fail

2020-07-03 Thread Yu-Hsuan Hsu
Log results of failed EC commands to identify a problem more easily. Replace cros_ec_cmd_xfer_status with cros_ec_cmd_xfer because the result has already been checked in this function. The wrapper is not needed. Signed-off-by: Yu-Hsuan Hsu --- sound/soc/codecs/cros_ec_codec.c | 9 - 1 f