Re: [PATCH v2] ASoC: Intel: avoid Oops if DMA setup fails

2019-05-02 Thread Mark Brown
On Mon, Apr 29, 2019 at 12:25:17PM -0600, Ross Zwisler wrote: > Currently in sst_dsp_new() if we get an error return from sst_dma_new() > we just print an error message and then still complete the function > successfully. This means that we are trying to run without sst->dma Please don't bury pat

Re: [PATCH v2] ASoC: Intel: avoid Oops if DMA setup fails

2019-04-29 Thread Pierre-Louis Bossart
On 4/29/19 1:25 PM, Ross Zwisler wrote: Currently in sst_dsp_new() if we get an error return from sst_dma_new() we just print an error message and then still complete the function successfully. This means that we are trying to run without sst->dma properly set up, which will result in NULL point

[PATCH v2] ASoC: Intel: avoid Oops if DMA setup fails

2019-04-29 Thread Ross Zwisler
Currently in sst_dsp_new() if we get an error return from sst_dma_new() we just print an error message and then still complete the function successfully. This means that we are trying to run without sst->dma properly set up, which will result in NULL pointer dereference when sst->dma is later used