Re: [PATCH v2] ALSA: line6: add hw monitor volume control for POD HD500

2020-05-24 Thread Takashi Iwai
On Sun, 24 May 2020 19:20:58 +0200, Vasily Khoruzhick wrote: > > > > +static const unsigned int float_zero_to_one_lookup[] = { > > > +0x, 0x3C23D70A, 0x3CA3D70A, 0x3CF5C28F, 0x3D23D70A, 0x3D4D, > > > +0x3D75C28F, 0x3D8F5C29, 0x3DA3D70A, 0x3DB851EC, 0x3DCD, 0x3DE147AE, > > > +0x3DF5

Re: [PATCH v2] ALSA: line6: add hw monitor volume control for POD HD500

2020-05-24 Thread Vasily Khoruzhick
On Sat, May 23, 2020 at 11:59 PM Takashi Iwai wrote: > Thanks for the patch. > The basic implementation looks good, but I see a few issues. > > +EXPORT_SYMBOL(line6_send_raw_message); > > Let's use EXPORT_SYMBOL_GPL() instead. Sure, will do. > > +static const unsigned int float_zero_to_one_loo

Re: [PATCH v2] ALSA: line6: add hw monitor volume control for POD HD500

2020-05-23 Thread Takashi Iwai
On Sat, 23 May 2020 19:49:57 +0200, Vasily Khoruzhick wrote: > > Add hw monitor volume control for POD HD500. The same change may > work for HD500X but I don't have it to test. > > Signed-off-by: Vasily Khoruzhick > --- > v2: clamp volume value to [0, ARRAY_SIZE() -1] in > podhd_set_monitor_

[PATCH v2] ALSA: line6: add hw monitor volume control for POD HD500

2020-05-23 Thread Vasily Khoruzhick
Add hw monitor volume control for POD HD500. The same change may work for HD500X but I don't have it to test. Signed-off-by: Vasily Khoruzhick --- v2: clamp volume value to [0, ARRAY_SIZE() -1] in podhd_set_monitor_level() sound/usb/line6/driver.c | 3 +- sound/usb/line6/driver.h | 4 ++