Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

2015-01-14 Thread Qais Yousef
On 01/13/2015 05:21 PM, James Hogan wrote: On 13 January 2015 15:16:10 GMT+00:00, Qais Yousef wrote: Will this really be helpful? I think it'll be more clutter (the backtrace on metag arch is not great): I suspect you don't have frame pointers enabled in your kernel config. That should impr

Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

2015-01-13 Thread Qais Yousef
On 01/13/2015 04:20 PM, Mark Brown wrote: On Tue, Jan 13, 2015 at 03:16:10PM +, Qais Yousef wrote: On 01/13/2015 02:59 PM, Vinod Koul wrote: being NULL, hence when trying to set rtd a few lines below we get an oops. It is a good practice to add the oops here Will this really be helpful? I

Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

2015-01-13 Thread James Hogan
On 13 January 2015 15:16:10 GMT+00:00, Qais Yousef wrote: >On 01/13/2015 02:59 PM, Vinod Koul wrote: >> On Tue, Jan 13, 2015 at 11:18:53AM +, Qais Yousef wrote: >>> In soc_new_compress() when rtd->dai_link->daynmic is set, we create >the pcm >>

Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

2015-01-13 Thread Mark Brown
On Tue, Jan 13, 2015 at 03:16:10PM +, Qais Yousef wrote: > On 01/13/2015 02:59 PM, Vinod Koul wrote: > >>being NULL, hence when trying to set rtd a few lines below we get an oops. > >It is a good practice to add the oops here > Will this really be helpful? I think it'll be more clutter (the b

Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

2015-01-13 Thread Qais Yousef
On 01/13/2015 02:59 PM, Vinod Koul wrote: On Tue, Jan 13, 2015 at 11:18:53AM +, Qais Yousef wrote: In soc_new_compress() when rtd->dai_link->daynmic is set, we create the pcm typo substreams with this call: ret = snd_pcm_new_internal

Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

2015-01-13 Thread Vinod Koul
On Tue, Jan 13, 2015 at 11:18:53AM +, Qais Yousef wrote: > In soc_new_compress() when rtd->dai_link->daynmic is set, we create the pcm typo > substreams with this call: > >ret = snd_pcm_new_internal(rtd->card->snd_card, new_name, num, >

[PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

2015-01-13 Thread Qais Yousef
In soc_new_compress() when rtd->dai_link->daynmic is set, we create the pcm substreams with this call: ret = snd_pcm_new_internal(rtd->card->snd_card, new_name, num, 1, 0, &be_pcm); which passes 0 as capture_count leading to be_pcm->streams[SNDRV_PCM_STRE