Re: [PATCH v2] [POWERPC] Fix CONFIG_SMP=n build break

2007-10-27 Thread Olof Johansson
On Sun, Oct 28, 2007 at 12:38:50PM +1100, Stephen Rothwell wrote: > Hi Olof, > > Just a trivial thing ... > > On Sat, 27 Oct 2007 12:28:51 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > > +u8 iic_get_target_id(int cpu) > > +{ > > + return per_cpu(iic, cpu).target_id; > > +} > > + > > +EX

Re: [PATCH v2] [POWERPC] Fix CONFIG_SMP=n build break

2007-10-27 Thread Stephen Rothwell
Hi Olof, Just a trivial thing ... On Sat, 27 Oct 2007 12:28:51 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > +u8 iic_get_target_id(int cpu) > +{ > + return per_cpu(iic, cpu).target_id; > +} > + > +EXPORT_SYMBOL_GPL(iic_get_target_id); We don't normally put a blank line between a functi

Re: [PATCH v2] [POWERPC] Fix CONFIG_SMP=n build break

2007-10-27 Thread Arnd Bergmann
On Saturday 27 October 2007, Olof Johansson wrote: > Fix two build errors on powerpc allyesconfig + CONFIG_SMP=n: > > arch/powerpc/platforms/built-in.o: In function `cpu_affinity_set': > arch/powerpc/platforms/cell/spu_priv1_mmio.c:78: undefined reference to > `.iic_get_target_id' > arch/powerpc/

[PATCH v2] [POWERPC] Fix CONFIG_SMP=n build break

2007-10-27 Thread Olof Johansson
Fix two build errors on powerpc allyesconfig + CONFIG_SMP=n: arch/powerpc/platforms/built-in.o: In function `cpu_affinity_set': arch/powerpc/platforms/cell/spu_priv1_mmio.c:78: undefined reference to `.iic_get_target_id' arch/powerpc/platforms/built-in.o: In function `iic_init_IRQ': arch/powerpc/