Re: [PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-15 Thread Bjorn Helgaas
On Fri, May 11, 2018 at 06:43:24AM -0400, Oza Pawandeep wrote: > This patch factors out error reporting callbacks, which are currently > tightly coupled with AER. > > DPC should be able to register callbacks and attempt recovery when DPC > trigger event occurs. > > Signed-off-by: Oza Pawandeep

Re: [PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-11 Thread poza
On 2018-05-11 21:24, Lukas Wunner wrote: On Fri, May 11, 2018 at 09:04:36PM +0530, p...@codeaurora.org wrote: On 2018-05-11 18:28, Lukas Wunner wrote: >On Fri, May 11, 2018 at 06:43:24AM -0400, Oza Pawandeep wrote: >>+void pcie_do_fatal_recovery(struct pci_dev *dev) >>+{ >>+ struct pci_dev

Re: [PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-11 Thread Lukas Wunner
On Fri, May 11, 2018 at 09:04:36PM +0530, p...@codeaurora.org wrote: > On 2018-05-11 18:28, Lukas Wunner wrote: > >On Fri, May 11, 2018 at 06:43:24AM -0400, Oza Pawandeep wrote: > >>+void pcie_do_fatal_recovery(struct pci_dev *dev) > >>+{ > >>+ struct pci_dev *udev; > >>+ struct pci_bus *parent

Re: [PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-11 Thread poza
On 2018-05-11 18:28, Lukas Wunner wrote: On Fri, May 11, 2018 at 06:43:24AM -0400, Oza Pawandeep wrote: +void pcie_do_fatal_recovery(struct pci_dev *dev) +{ + struct pci_dev *udev; + struct pci_bus *parent; + struct pci_dev *pdev, *temp; + pci_ers_result_t result = PCI_ER

Re: [PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-11 Thread Lukas Wunner
On Fri, May 11, 2018 at 06:43:24AM -0400, Oza Pawandeep wrote: > +void pcie_do_fatal_recovery(struct pci_dev *dev) > +{ > + struct pci_dev *udev; > + struct pci_bus *parent; > + struct pci_dev *pdev, *temp; > + pci_ers_result_t result = PCI_ERS_RESULT_RECOVERED; > + struct aer_b

[PATCH v16 5/9] PCI/AER: Factor out error reporting from AER

2018-05-11 Thread Oza Pawandeep
This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to register callbacks and attempt recovery when DPC trigger event occurs. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/Makefile b/drivers/pci/pcie/Makefile index 800e