Re: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page()

2020-07-20 Thread Alex Shi
在 2020/7/20 下午4:49, Kirill A. Shutemov 写道: >> >> Split_huge_page() must start with PageLRU(head), and we are holding the >> lru_lock here. If the head was cleared lru bit unexpected, tracking it. >> >> Signed-off-by: Alex Shi > Reviewed-by: Kirill A. Shutemov Hi Kirill, Millions thanks for r

Re: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page()

2020-07-20 Thread Kirill A. Shutemov
:37 +0800 > Subject: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in > split_huge_page() > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > Split_huge_page() must start with PageLRU(head), and we are holding the

Re: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page()

2020-07-17 Thread Alex Shi
Add a VM_WARN_ON for tracking. and updated comments for the code. Thanks --- >From f1381a1547625a6521777bf9235823d8fbd00dac Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Fri, 10 Jul 2020 16:54:37 +0800 Subject: [PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_p

[PATCH v16 14/22] mm/thp: add tail pages into lru anyway in split_huge_page()

2020-07-10 Thread Alex Shi
split_huge_page() must start with PageLRU(head), but lru bit *maybe* cleared by isolate_lru_page, anyway the head still in lru list, since we still held the lru_lock. Signed-off-by: Alex Shi Cc: Kirill A. Shutemov Cc: Andrew Morton Cc: Johannes Weiner Cc: Matthew Wilcox Cc: Hugh Dickins Cc: