Re: [virtio-dev] Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-20 Thread Wei Wang
On 08/19/2017 02:10 AM, Michael S. Tsirkin wrote: On Fri, Aug 18, 2017 at 04:36:06PM +0800, Wei Wang wrote: On 08/18/2017 10:28 AM, Michael S. Tsirkin wrote: On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: Add a new vq to report hints of guest free pages to the host. Signed-off-by:

Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-20 Thread Wei Wang
On 08/19/2017 02:26 AM, Michael S. Tsirkin wrote: On Fri, Aug 18, 2017 at 04:41:41PM +0800, Wei Wang wrote: On 08/18/2017 10:13 AM, Michael S. Tsirkin wrote: On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: Add a new vq to report hints of guest free pages to the host. Please add some

Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-18 Thread Michael S. Tsirkin
On Fri, Aug 18, 2017 at 04:41:41PM +0800, Wei Wang wrote: > On 08/18/2017 10:13 AM, Michael S. Tsirkin wrote: > > On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: > > > Add a new vq to report hints of guest free pages to the host. > > Please add some text here explaining the report_free_pa

Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-18 Thread Michael S. Tsirkin
On Fri, Aug 18, 2017 at 04:36:06PM +0800, Wei Wang wrote: > On 08/18/2017 10:28 AM, Michael S. Tsirkin wrote: > > On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: > > > Add a new vq to report hints of guest free pages to the host. > > > > > > Signed-off-by: Wei Wang > > > Signed-off-by:

Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-18 Thread Wei Wang
On 08/18/2017 10:13 AM, Michael S. Tsirkin wrote: On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: Add a new vq to report hints of guest free pages to the host. Please add some text here explaining the report_free_page_signal thing. I also really think we need some kind of ID in the

Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-18 Thread Wei Wang
On 08/18/2017 10:28 AM, Michael S. Tsirkin wrote: On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: Add a new vq to report hints of guest free pages to the host. Signed-off-by: Wei Wang Signed-off-by: Liang Li --- drivers/virtio/virtio_balloon.c | 167 +++

Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-17 Thread Michael S. Tsirkin
On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: > Add a new vq to report hints of guest free pages to the host. > > Signed-off-by: Wei Wang > Signed-off-by: Liang Li > --- > drivers/virtio/virtio_balloon.c | 167 > +++- > include/uapi/linux/virtio_

Re: [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-17 Thread Michael S. Tsirkin
On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: > Add a new vq to report hints of guest free pages to the host. Please add some text here explaining the report_free_page_signal thing. I also really think we need some kind of ID in the buffer to do a handshake. whenever id changes you a

[PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-16 Thread Wei Wang
Add a new vq to report hints of guest free pages to the host. Signed-off-by: Wei Wang Signed-off-by: Liang Li --- drivers/virtio/virtio_balloon.c | 167 +++- include/uapi/linux/virtio_balloon.h | 1 + 2 files changed, 147 insertions(+), 21 deletions(-) dif