Re: [PATCH v14 2/3] power-domain: rockchip: add power domain driver

2015-06-29 Thread Caesar Wang
Hi Uffe, 在 2015年06月25日 23:33, Ulf Hansson 写道: [...] +#include clk-provider.h, why? The following is needed. _clk_get_name(clk) I see, you need it for for the dev_dbg(). I think you shall use "%pC" as the formatting string for the dev_dbg() message, since that will take care of printing

Re: [PATCH v14 2/3] power-domain: rockchip: add power domain driver

2015-06-25 Thread Ulf Hansson
[...] >>> +#include >> >> clk-provider.h, why? > > > The following is needed. > > _clk_get_name(clk) I see, you need it for for the dev_dbg(). I think you shall use "%pC" as the formatting string for the dev_dbg() message, since that will take care of printing the clock name for you. [...] >>

Re: [PATCH v14 2/3] power-domain: rockchip: add power domain driver

2015-06-13 Thread Caesar Wang
Ulf, Thanks for your comments.:-) 在 2015年05月28日 18:38, Ulf Hansson 写道: On 24 April 2015 at 10:07, Caesar Wang wrote: In order to meet high performance and low power requirements, a power management unit is designed or saving power when RK3288 in low power mode. The RK3288 PMU is dedicated f

Re: [PATCH v14 2/3] power-domain: rockchip: add power domain driver

2015-05-28 Thread Ulf Hansson
On 24 April 2015 at 10:07, Caesar Wang wrote: > In order to meet high performance and low power requirements, a power > management unit is designed or saving power when RK3288 in low power > mode. > The RK3288 PMU is dedicated for managing the power ot the whole chip. > > Signed-off-by: jinkun.hon

[PATCH v14 2/3] power-domain: rockchip: add power domain driver

2015-04-24 Thread Caesar Wang
In order to meet high performance and low power requirements, a power management unit is designed or saving power when RK3288 in low power mode. The RK3288 PMU is dedicated for managing the power ot the whole chip. Signed-off-by: jinkun.hong Signed-off-by: Caesar Wang --- arch/arm/mach-rockchi