Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-27 Thread Thierry Reding
On Thu, Sep 24, 2020 at 04:16:59PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 24, 2020 at 04:23:34PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 24, 2020 at 08:55:34AM +0200, Uwe Kleine-König wrote: > > > On Tue, Sep 15, 2020 at 04:23:37PM +0800, Rahul Tanwar wrote: > > > > ... > > > > > > +

Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-25 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 04:16:59PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 24, 2020 at 04:23:34PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 24, 2020 at 08:55:34AM +0200, Uwe Kleine-König wrote: ... > > True. And above dev_err_probe() is not needed. > > You argue that dev_err_probe() giv

Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-25 Thread Tanwar, Rahul
Hi Uwe, Thanks for review & feedback. On 24/9/2020 2:55 pm, Uwe Kleine-König wrote: > Hello, > > (hhm Thierry already announced to have taken this patch, so my review is > late.) > > On Tue, Sep 15, 2020 at 04:23:37PM +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PW

Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-24 Thread Uwe Kleine-König
On Thu, Sep 24, 2020 at 04:23:34PM +0300, Andy Shevchenko wrote: > On Thu, Sep 24, 2020 at 08:55:34AM +0200, Uwe Kleine-König wrote: > > On Tue, Sep 15, 2020 at 04:23:37PM +0800, Rahul Tanwar wrote: > > ... > > > > + ret = lgm_clk_enable(dev, pc); > > > + if (ret) { > > > + dev_err(dev, "

Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-24 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 08:55:34AM +0200, Uwe Kleine-König wrote: > On Tue, Sep 15, 2020 at 04:23:37PM +0800, Rahul Tanwar wrote: ... > > + ret = lgm_clk_enable(dev, pc); > > + if (ret) { > > + dev_err(dev, "failed to enable clock\n"); > > You used dev_err_probe four times for six

Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-24 Thread Tanwar, Rahul
On 24/9/2020 3:12 pm, Thierry Reding wrote: > On Thu, Sep 24, 2020 at 08:55:34AM +0200, Uwe Kleine-König wrote: >> Hello, >> >> (hhm Thierry already announced to have taken this patch, so my review is >> late.) > There's also a build warning in linux-next caused by this patch, so I'm > going to

Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-24 Thread Thierry Reding
On Thu, Sep 24, 2020 at 08:55:34AM +0200, Uwe Kleine-König wrote: > Hello, > > (hhm Thierry already announced to have taken this patch, so my review is > late.) There's also a build warning in linux-next caused by this patch, so I'm going to back it out. Rahul, please address Uwe's comments and

Re: [PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-23 Thread Uwe Kleine-König
Hello, (hhm Thierry already announced to have taken this patch, so my review is late.) On Tue, Sep 15, 2020 at 04:23:37PM +0800, Rahul Tanwar wrote: > Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > This PWM controller does not have any other consumer, it is a > dedicated PWM c

[PATCH v13 2/2] Add PWM fan controller driver for LGM SoC

2020-09-15 Thread Rahul Tanwar
Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. This PWM controller does not have any other consumer, it is a dedicated PWM controller for fan attached to the system. Add driver for this PWM fan controller. Signed-off-by: Rahul Tanwar Reviewed-by: Andy Shevchenko --- drivers/pw