RE: Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Daejun Park
> > On Mon, 2020-12-07 at 19:35 +0100, Greg KH wrote: > > > On Mon, Dec 07, 2020 at 06:26:03PM +, Christoph Hellwig wrote: > > > > On Mon, Dec 07, 2020 at 07:23:12PM +0100, Greg KH wrote: > > > > > What "real workload" test can be run on this to help show if it > > > > > is useful or not? Thes

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Greg KH
On Mon, Dec 07, 2020 at 10:54:58AM -0800, James Bottomley wrote: > On Mon, 2020-12-07 at 19:35 +0100, Greg KH wrote: > > On Mon, Dec 07, 2020 at 06:26:03PM +, Christoph Hellwig wrote: > > > On Mon, Dec 07, 2020 at 07:23:12PM +0100, Greg KH wrote: > > > > What "real workload" test can be run on

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread James Bottomley
On Mon, 2020-12-07 at 19:35 +0100, Greg KH wrote: > On Mon, Dec 07, 2020 at 06:26:03PM +, Christoph Hellwig wrote: > > On Mon, Dec 07, 2020 at 07:23:12PM +0100, Greg KH wrote: > > > What "real workload" test can be run on this to help show if it > > > is useful or not? These vendors seem to th

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Greg KH
On Mon, Dec 07, 2020 at 07:35:03PM +0100, Greg KH wrote: > On Mon, Dec 07, 2020 at 06:26:03PM +, Christoph Hellwig wrote: > > On Mon, Dec 07, 2020 at 07:23:12PM +0100, Greg KH wrote: > > > What "real workload" test can be run on this to help show if it is > > > useful or not? These vendors see

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Greg KH
On Mon, Dec 07, 2020 at 06:26:03PM +, Christoph Hellwig wrote: > On Mon, Dec 07, 2020 at 07:23:12PM +0100, Greg KH wrote: > > What "real workload" test can be run on this to help show if it is > > useful or not? These vendors seem to think it helps for some reason, > > otherwise they wouldn't

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Christoph Hellwig
On Mon, Dec 07, 2020 at 07:23:12PM +0100, Greg KH wrote: > What "real workload" test can be run on this to help show if it is > useful or not? These vendors seem to think it helps for some reason, > otherwise they wouldn't have added it to their silicon :) > > Should they run fio? If so, any hin

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Greg KH
On Mon, Dec 07, 2020 at 06:06:55PM +, Christoph Hellwig wrote: > On Mon, Dec 07, 2020 at 06:56:23PM +0100, Greg KH wrote: > > On Tue, Nov 03, 2020 at 01:40:21PM +0900, Daejun Park wrote: > > > Changelog: > > > > > > v12 -> v13 > > > 1. Cleanup codes by comments from Can Guo. > > > 2. Add HPB r

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Christoph Hellwig
On Mon, Dec 07, 2020 at 06:56:23PM +0100, Greg KH wrote: > On Tue, Nov 03, 2020 at 01:40:21PM +0900, Daejun Park wrote: > > Changelog: > > > > v12 -> v13 > > 1. Cleanup codes by comments from Can Guo. > > 2. Add HPB related descriptor/flag/attributes in sysfs. > > 3. Change base commit from 5.10/s

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-12-07 Thread Greg KH
On Tue, Nov 03, 2020 at 01:40:21PM +0900, Daejun Park wrote: > Changelog: > > v12 -> v13 > 1. Cleanup codes by comments from Can Guo. > 2. Add HPB related descriptor/flag/attributes in sysfs. > 3. Change base commit from 5.10/scsi-queue to 5.11/scsi-queue. What ever happened to this patchset? Di

Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-11-05 Thread Can Guo
On 2020-11-03 12:40, Daejun Park wrote: Changelog: v12 -> v13 1. Cleanup codes by comments from Can Guo. 2. Add HPB related descriptor/flag/attributes in sysfs. 3. Change base commit from 5.10/scsi-queue to 5.11/scsi-queue. If you have changed the code based by comments left on Google gerrit,

[PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support

2020-11-02 Thread Daejun Park
Changelog: v12 -> v13 1. Cleanup codes by comments from Can Guo. 2. Add HPB related descriptor/flag/attributes in sysfs. 3. Change base commit from 5.10/scsi-queue to 5.11/scsi-queue. v11 -> v12 1. Fixed to return error value when HPB fails to initialize pinned active region. 2. Fixed to disable