Re: [PATCH v12 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

On Wed, 15 May 2019, masonccy...@mxic.com.tw wrote: > Hi Jones, > > > > > + > > > +struct rpc_spi { > > > + struct rpc_mfd *mfd; > > > > The term MFD isn't a real thing. What you're obtaining below is > > driver data and is normally articulated as 'ddata' in drivers. > > yes, it's just impl

Re: [PATCH v12 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

Hi Jones, > > + > > +struct rpc_spi { > > + struct rpc_mfd *mfd; > > The term MFD isn't a real thing. What you're obtaining below is > driver data and is normally articulated as 'ddata' in drivers. yes, it's just imply that data is from MFD. Should I rename "mfd" ? > > > + u32 cur_speed

Re: [PATCH v12 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

On Wed, 24 Apr 2019, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > Signed-off-by: Mason Yang > Signed-off-by: Sergei Shtylyov > --- > drivers/spi/Kconfig | 6 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-renesas-rpc.c | 571 > ++