Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

On Sun, Aug 5, 2018 at 7:07 PM, Masami Hiramatsu wrote: > On Sun, 5 Aug 2018 09:46:56 -0700 > Joel Fernandes wrote: > >> Hi Masami, >> >> On Fri, Aug 3, 2018 at 9:51 PM, Joel Fernandes wrote: >> [...] >> >> On Thu, 2 Aug 2018 19:57:09 -0700 >> >> Joel Fernandes wrote: >> >> >> >>> Hi Masami, >>

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

On Sun, 5 Aug 2018 09:46:56 -0700 Joel Fernandes wrote: > Hi Masami, > > On Fri, Aug 3, 2018 at 9:51 PM, Joel Fernandes wrote: > [...] > >> On Thu, 2 Aug 2018 19:57:09 -0700 > >> Joel Fernandes wrote: > >> > >>> Hi Masami, > >>> > >>> On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu > >>> wr

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

Hi Masami, On Fri, Aug 3, 2018 at 9:51 PM, Joel Fernandes wrote: [...] >> On Thu, 2 Aug 2018 19:57:09 -0700 >> Joel Fernandes wrote: >> >>> Hi Masami, >>> >>> On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu >>> wrote: >>> > Hi Joel, >>> > >>> > I found this caused several issues when testing

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

Hi Masami, On Fri, Aug 3, 2018 at 12:23 AM, Masami Hiramatsu wrote: > Hi Joel, > > Thank you for trying to fix that. > > On Thu, 2 Aug 2018 19:57:09 -0700 > Joel Fernandes wrote: > >> Hi Masami, >> >> On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu wrote: >> > Hi Joel, >> > >> > I found this c

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

On Thu, 2 Aug 2018 19:57:09 -0700 Joel Fernandes wrote: > Hi Masami, > > On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu wrote: > > Hi Joel, > > > > I found this caused several issues when testing ftrace. > > > > #1) ftrace boottest (FTRACE_STARTUP_TEST) fails > > This sadly appears to be a r

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

Hi Joel, Thank you for trying to fix that. On Thu, 2 Aug 2018 19:57:09 -0700 Joel Fernandes wrote: > Hi Masami, > > On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu wrote: > > Hi Joel, > > > > I found this caused several issues when testing ftrace. > > > > #1) ftrace boottest (FTRACE_STARTUP_

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

Hi Masami, On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu wrote: > Hi Joel, > > I found this caused several issues when testing ftrace. > > #1) ftrace boottest (FTRACE_STARTUP_TEST) fails This sadly appears to be a real issue. The startup test for "preemptirqsoff" tracer fails, however it pass

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

Hi Joel, I found this caused several issues when testing ftrace. #1) ftrace boottest (FTRACE_STARTUP_TEST) fails #2) mmiotrace reports "IRQs not enabled as expected" error #3) lock subsystem event boottest causes "IRQs not disabled as expected" error (sometimes) #4) ftracetest test.d/event/tople

[PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

From: "Joel Fernandes (Google)" This series contains the last 2 patches with minor changes suggested by Peter and Steven, and an additional clean up of get_lock_stats as suggested by Peter. The preempt/irq tracepoints exist but not everything in the kernel is using it whenever they need to be no