Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-04-07 Thread Dan Williams
On Thu, Apr 7, 2022 at 11:05 PM Shiyang Ruan wrote: > > > > 在 2022/3/30 14:00, Christoph Hellwig 写道: > >> @@ -1892,6 +1893,8 @@ xfs_free_buftarg( > >> list_lru_destroy(&btp->bt_lru); > >> > >> blkdev_issue_flush(btp->bt_bdev); > >> +if (btp->bt_daxdev) > >> +dax_unregiste

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-04-07 Thread Dan Williams
On Tue, Mar 29, 2022 at 11:01 PM Christoph Hellwig wrote: > > > @@ -1892,6 +1893,8 @@ xfs_free_buftarg( > > list_lru_destroy(&btp->bt_lru); > > > > blkdev_issue_flush(btp->bt_bdev); > > + if (btp->bt_daxdev) > > + dax_unregister_holder(btp->bt_daxdev, btp->bt_mount); >

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-04-07 Thread Shiyang Ruan
在 2022/3/30 14:00, Christoph Hellwig 写道: @@ -1892,6 +1893,8 @@ xfs_free_buftarg( list_lru_destroy(&btp->bt_lru); blkdev_issue_flush(btp->bt_bdev); + if (btp->bt_daxdev) + dax_unregister_holder(btp->bt_daxdev, btp->bt_mount); fs_put_dax(btp->bt_daxdev)

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-03-30 Thread Christoph Hellwig
On Wed, Mar 30, 2022 at 11:16:10PM +0800, Shiyang Ruan wrote: > > > +#if IS_ENABLED(CONFIG_MEMORY_FAILURE) && IS_ENABLED(CONFIG_FS_DAX) > > > > No real need for the IS_ENABLED. Also any reason to even build this > > file if the options are not set? It seems like > > xfs_dax_holder_operations sho

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-03-30 Thread Shiyang Ruan
在 2022/3/30 14:00, Christoph Hellwig 写道: @@ -1892,6 +1893,8 @@ xfs_free_buftarg( list_lru_destroy(&btp->bt_lru); blkdev_issue_flush(btp->bt_bdev); + if (btp->bt_daxdev) + dax_unregister_holder(btp->bt_daxdev, btp->bt_mount); fs_put_dax(btp->bt_daxdev)

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-03-29 Thread Christoph Hellwig
> @@ -1892,6 +1893,8 @@ xfs_free_buftarg( > list_lru_destroy(&btp->bt_lru); > > blkdev_issue_flush(btp->bt_bdev); > + if (btp->bt_daxdev) > + dax_unregister_holder(btp->bt_daxdev, btp->bt_mount); > fs_put_dax(btp->bt_daxdev); > > kmem_free(btp); > @@ -193

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-02-27 Thread kernel test robot
Hi Shiyang, Thank you for the patch! Yet something to improve: [auto build test ERROR on xfs-linux/for-next] [also build test ERROR on linux/master] [cannot apply to hnaz-mm/master linus/master v5.17-rc5 next-20220225] [If your patch is applied to the wrong git tree, kindly drop us a note. And wh

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-02-27 Thread kernel test robot
Hi Shiyang, Thank you for the patch! Yet something to improve: [auto build test ERROR on xfs-linux/for-next] [also build test ERROR on linux/master] [cannot apply to hnaz-mm/master linus/master v5.17-rc5 next-20220225] [If your patch is applied to the wrong git tree, kindly drop us a note. And wh

Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-02-27 Thread kernel test robot
Hi Shiyang, Thank you for the patch! Yet something to improve: [auto build test ERROR on xfs-linux/for-next] [also build test ERROR on linux/master] [cannot apply to hnaz-mm/master linus/master v5.17-rc5 next-20220225] [If your patch is applied to the wrong git tree, kindly drop us a note. And wh

[PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS

2022-02-27 Thread Shiyang Ruan
Introduce xfs_notify_failure.c to handle failure related works, such as implement ->notify_failure(), register/unregister dax holder in xfs, and so on. If the rmap feature of XFS enabled, we can query it to find files and metadata which are associated with the corrupt data. For now all we do is k