Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-09-07 Thread Jens Wiklander
Hi Zengtao, On Wed, Sep 07, 2016 at 03:49:38PM +0800, Zeng Tao wrote: > Hi all: > > I have gone through the patch, and i find one limit for RPC call from > TEE to REE. In this patch, RPC commands are fixed and it supports a > limited set of commands. If you want to add your own RPC command then

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-09-07 Thread Zeng Tao
Hi all: I have gone through the patch, and i find one limit for RPC call from TEE to REE. In this patch, RPC commands are fixed and it supports a limited set of commands. If you want to add your own RPC command then you need to change the source code of the driver. I don't know how much work to

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-09-02 Thread Andrew F. Davis
On 09/02/2016 05:49 AM, Jens Wiklander wrote: > On Thu, Sep 01, 2016 at 01:06:04PM -0500, Andrew F. Davis wrote: >> On 09/01/2016 04:22 AM, Jens Wiklander wrote: >>> On Wed, Aug 31, 2016 at 11:40:20AM -0500, Andrew F. Davis wrote: On 08/31/2016 08:50 AM, Jens Wiklander wrote: > On Tue, Aug

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-09-02 Thread Jens Wiklander
On Thu, Sep 01, 2016 at 01:06:04PM -0500, Andrew F. Davis wrote: > On 09/01/2016 04:22 AM, Jens Wiklander wrote: > > On Wed, Aug 31, 2016 at 11:40:20AM -0500, Andrew F. Davis wrote: > >> On 08/31/2016 08:50 AM, Jens Wiklander wrote: > >>> On Tue, Aug 30, 2016 at 03:23:24PM -0500, Andrew F. Davis wr

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-09-01 Thread Andrew F. Davis
On 09/01/2016 04:22 AM, Jens Wiklander wrote: > On Wed, Aug 31, 2016 at 11:40:20AM -0500, Andrew F. Davis wrote: >> On 08/31/2016 08:50 AM, Jens Wiklander wrote: >>> On Tue, Aug 30, 2016 at 03:23:24PM -0500, Andrew F. Davis wrote: On 08/22/2016 08:00 AM, Jens Wiklander wrote: > +static str

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-09-01 Thread Jens Wiklander
On Wed, Aug 31, 2016 at 11:40:20AM -0500, Andrew F. Davis wrote: > On 08/31/2016 08:50 AM, Jens Wiklander wrote: > > On Tue, Aug 30, 2016 at 03:23:24PM -0500, Andrew F. Davis wrote: > >> On 08/22/2016 08:00 AM, Jens Wiklander wrote: > >>> +static struct tee_shm_pool * > >>> +optee_config_shm_iorema

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-08-31 Thread Volodymyr Babchuk
On 22.08.16 16:00, Jens Wiklander wrote: On 31.08.16 16:50, Jerome Forissier wrote:Adds a OP-TEE driver which also can be compiled as a loadable module. * Targets ARM and ARM64 * Supports using reserved memory from OP-TEE as shared memory * Probes OP-TEE version using SMCs * Accepts requests

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-08-31 Thread Andrew F. Davis
On 08/31/2016 08:50 AM, Jens Wiklander wrote: > On Tue, Aug 30, 2016 at 03:23:24PM -0500, Andrew F. Davis wrote: >> On 08/22/2016 08:00 AM, Jens Wiklander wrote: >>> +static struct tee_shm_pool * >>> +optee_config_shm_ioremap(struct device *dev, optee_invoke_fn *invoke_fn, >>> +

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-08-31 Thread Jens Wiklander
On Tue, Aug 30, 2016 at 03:23:24PM -0500, Andrew F. Davis wrote: > On 08/22/2016 08:00 AM, Jens Wiklander wrote: > > + /* > > +* We add ourselves to the queue, but we don't wait. This > > +* guarentees that we don't lose a completion if secure world > > ^^ spelling > [snip]

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-08-30 Thread Andrew F. Davis
On 08/22/2016 08:00 AM, Jens Wiklander wrote: > + /* > + * We add ourselves to the queue, but we don't wait. This > + * guarentees that we don't lose a completion if secure world ^^ spelling [snip] > +static struct tee_shm *get_msg_arg(struct tee_context *ctx, size_t >

Re: [PATCH v11 3/4] tee: add OP-TEE driver

2016-08-23 Thread Jérôme Forissier
On 08/22/2016 03:00 PM, Jens Wiklander wrote: > Adds a OP-TEE driver which also can be compiled as a loadable module. > > * Targets ARM and ARM64 > * Supports using reserved memory from OP-TEE as shared memory > * Probes OP-TEE version using SMCs > * Accepts requests on privileged and unprivileg

[PATCH v11 3/4] tee: add OP-TEE driver

2016-08-22 Thread Jens Wiklander
Adds a OP-TEE driver which also can be compiled as a loadable module. * Targets ARM and ARM64 * Supports using reserved memory from OP-TEE as shared memory * Probes OP-TEE version using SMCs * Accepts requests on privileged and unprivileged device * Uses OPTEE message protocol version 2 to communi