Sorry for resending this mail.
I forgot to use plain text mode in the previous mail.
On Thu, Oct 22, 2020 at 6:12 PM Srinivas Kandagatla
wrote:
>
>
>
> On 22/10/2020 04:29, Tzung-Bi Shih wrote:
> > Hi, sorry for jumping into your discussion but I am trying to
> > summarize them to make sure we are
On 22/10/2020 04:29, Tzung-Bi Shih wrote:
Hi, sorry for jumping into your discussion but I am trying to
summarize them to make sure we are on the same page. Pardon me to
manually copy-and-paste partial sentences to quote.
ACK:
- Don't expose DAI connections in compatible strings.
- Use "mode
Hi, sorry for jumping into your discussion but I am trying to
summarize them to make sure we are on the same page. Pardon me to
manually copy-and-paste partial sentences to quote.
ACK:
- Don't expose DAI connections in compatible strings.
- Use "model" DT property to make the card more UCM2-frien
On Wed, Oct 21, 2020 at 01:00:54PM +0100, Srinivas Kandagatla wrote:
> This is totally not very useful w.r.t UCM2 and makes it very difficult to
> common up parts of the configs.
> My suggestions are.
> 1. set card->driver_name to something more sensible in your sound card
> driver.
> 2. set lon
On 20/10/2020 19:54, Cheng-yi Chiang wrote:
Not with the compatible string!
Currently card name, and long name are exactly same in all Qualcomm
soundcards, which makes it very difficult to identify how those boards
re wired up at UCM2 level. So the plan is to properly populate card long
name
On Wed, Oct 21, 2020 at 02:51:33AM +0800, Cheng-yi Chiang wrote:
> On Tue, Oct 20, 2020 at 10:37 PM Mark Brown wrote:
> > If the device has both front and rear mics and only one can be active at
> > once that seems obvious and sensible. If the devices only have one of
> > these then this seems l
On Tue, Oct 20, 2020 at 10:55 PM Srinivas Kandagatla
wrote:
>
>
>
> On 20/10/2020 15:37, Mark Brown wrote:
> > I don't understand what "logic scattered in various dtsi files" means,
> > sorry.
> >
> >> Yes, that should work to describe the dailink we are using.
> >> But a more tricky issue is how
On Tue, Oct 20, 2020 at 10:37 PM Mark Brown wrote:
>
> On Tue, Oct 20, 2020 at 09:37:05PM +0800, Cheng-yi Chiang wrote:
>
> > May I know your suggestion on Ajye's patch "ASoC: qcom: sc7180: Modify
> > machine driver for 2mic" ?
>
> > https://lore.kernel.org/r/20200928063744.525700-3-ajye_hu...@com
On 20/10/2020 15:37, Mark Brown wrote:
I don't understand what "logic scattered in various dtsi files" means,
sorry.
Yes, that should work to describe the dailink we are using.
But a more tricky issue is how to do calls like setting PLL in dai startup ops.
...
I think that asking a generi
On Tue, Oct 20, 2020 at 09:37:05PM +0800, Cheng-yi Chiang wrote:
> May I know your suggestion on Ajye's patch "ASoC: qcom: sc7180: Modify
> machine driver for 2mic" ?
> https://lore.kernel.org/r/20200928063744.525700-3-ajye_hu...@compal.corp-partner.google.com
> I think adding code in the machin
On Fri, Oct 16, 2020 at 12:13 AM Mark Brown wrote:
>
> On Thu, Oct 15, 2020 at 03:59:26PM +0800, Cheng-yi Chiang wrote:
> > On Tue, Oct 13, 2020 at 6:36 PM Srinivas Kandagatla
>
> > > > +properties:
> > > > + compatible:
> > > > +const: qcom,sc7180-sndcard-rt5682-m98357-1mic
>
> > > This info
On Thu, Oct 15, 2020 at 03:59:26PM +0800, Cheng-yi Chiang wrote:
> On Tue, Oct 13, 2020 at 6:36 PM Srinivas Kandagatla
> > > +properties:
> > > + compatible:
> > > +const: qcom,sc7180-sndcard-rt5682-m98357-1mic
> > This information can come from the dai link description itself, why
> > shoul
On Tue, Oct 13, 2020 at 6:36 PM Srinivas Kandagatla
wrote:
>
> Hi Cheng,
>
> Sorry for such late review w.r.t compatibles,
>
Hi Srini,
Thank you for taking another look!
> On 14/09/2020 09:06, Cheng-Yi Chiang wrote:
> > +---
> > +$id:http://devicetree.org/schemas/sound/qcom,sc7180.yaml#
> > +$sch
Hi Cheng,
Sorry for such late review w.r.t compatibles,
On 14/09/2020 09:06, Cheng-Yi Chiang wrote:
+---
+$id:http://devicetree.org/schemas/sound/qcom,sc7180.yaml#
+$schema:http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver
+
+mainta
On Tue, Sep 15, 2020 at 8:44 PM Cheng-yi Chiang wrote:
>
> On Tue, Sep 15, 2020 at 1:48 AM Rob Herring wrote:
> >
> > On Mon, 14 Sep 2020 16:06:18 +0800, Cheng-Yi Chiang wrote:
> > > Add devicetree bindings documentation file for sc7180 sound card.
> > >
> > > Signed-off-by: Cheng-Yi Chiang
> >
On Tue, Sep 15, 2020 at 1:48 AM Rob Herring wrote:
>
> On Mon, 14 Sep 2020 16:06:18 +0800, Cheng-Yi Chiang wrote:
> > Add devicetree bindings documentation file for sc7180 sound card.
> >
> > Signed-off-by: Cheng-Yi Chiang
> > ---
> > .../bindings/sound/qcom,sc7180.yaml | 130 +
On Mon, 14 Sep 2020 16:06:18 +0800, Cheng-Yi Chiang wrote:
> Add devicetree bindings documentation file for sc7180 sound card.
>
> Signed-off-by: Cheng-Yi Chiang
> ---
> .../bindings/sound/qcom,sc7180.yaml | 130 ++
> 1 file changed, 130 insertions(+)
> create mode 100
Add devicetree bindings documentation file for sc7180 sound card.
Signed-off-by: Cheng-Yi Chiang
---
.../bindings/sound/qcom,sc7180.yaml | 130 ++
1 file changed, 130 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml
diff --git
18 matches
Mail list logo
