Re: [PATCH v10 44/46] nfs: Add richacl support

2015-10-12 Thread Andreas Gruenbacher
Anna, On Mon, Oct 12, 2015 at 4:39 PM, Anna Schumaker wrote: > I'm not a fan of the "one giant function" approach. Is there any way to > split richacl_from_nfs4_acl() into several smaller functions? sure, parsing the usr/group identifier could be put in a separate function, for example. That

Re: [PATCH v10 44/46] nfs: Add richacl support

2015-10-12 Thread Anna Schumaker
Hi Andreas, On 10/11/2015 06:58 PM, Andreas Gruenbacher wrote: > From: Andreas Gruenbacher > > Add support for the "system.richacl" xattr in nfs. The existing > "system.nfs4_acl" xattr on nfs doesn't map user and group names to uids > and gids; the "system.richacl" xattr does, and only keeps th

[PATCH v10 44/46] nfs: Add richacl support

2015-10-11 Thread Andreas Gruenbacher
From: Andreas Gruenbacher Add support for the "system.richacl" xattr in nfs. The existing "system.nfs4_acl" xattr on nfs doesn't map user and group names to uids and gids; the "system.richacl" xattr does, and only keeps the on-the-wire names when there is no mapping. This allows to copy permiss