Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-05 Thread Fu Wei
On 5 February 2016 at 00:25, Mathieu Poirier wrote: > On 3 February 2016 at 10:18, wrote: >> From: Fu Wei >> >> According to Server Base System Architecture (SBSA) specification, >> the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0) >> is for alerting the system by interru

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-05 Thread Fu Wei
Hi On 5 February 2016 at 00:46, Guenter Roeck wrote: > On 02/04/2016 08:37 AM, Timur Tabi wrote: >> >> Will Deacon wrote: +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >+{ >+struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >+ >+/* >+* Writi

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-04 Thread Guenter Roeck
On 02/04/2016 08:37 AM, Timur Tabi wrote: Will Deacon wrote: +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >+{ >+struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >+ >+/* >+* Writing WRR for an explicit watchdog refresh. >+* You can write anyting(like 0xc0ffee). >+*/

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-04 Thread Timur Tabi
Will Deacon wrote: +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >+{ >+ struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >+ >+ /* >+ * Writing WRR for an explicit watchdog refresh. >+ * You can write anyting(like 0xc0ffee). >+ */ >+ writel(0xc0ffee, gwdt->refresh_base + SBSA

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-04 Thread Will Deacon
On Thu, Feb 04, 2016 at 01:18:42AM +0800, fu@linaro.org wrote: > +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) > +{ > + struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); > + > + /* > + * Writing WRR for an explicit watchdog refresh. > + * You can write anyting(like 0xc0

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-04 Thread Mathieu Poirier
On 3 February 2016 at 10:18, wrote: > From: Fu Wei > > According to Server Base System Architecture (SBSA) specification, > the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0) > is for alerting the system by interrupt, the second one (WS1) is a real > hardware reset. > > Thi

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-03 Thread Timur Tabi
Fu Wei wrote: static const struct platform_device_id sbsa_gwdt_pdev_match[] = { { .name = "sbsa-gwdt", }, {}, }; MODULE_DEVICE_TABLE(platform, sbsa_gwdt_pdev_match); Ok, thanks.

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-03 Thread Fu Wei
On 4 February 2016 at 01:58, Timur Tabi wrote: > Fu Wei wrote: >> >> I have posted GTDT support separately :https://lkml.org/lkml/2016/2/1/660 >> >> devicetree driver and GTDT driver both export sbsa gwdt info to >> "platform resource". >> >> this driver get hardware info from platform resource.

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-03 Thread Timur Tabi
Fu Wei wrote: I have posted GTDT support separately :https://lkml.org/lkml/2016/2/1/660 devicetree driver and GTDT driver both export sbsa gwdt info to "platform resource". this driver get hardware info from platform resource. I must be missing something. How does the driver probe? It only

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-03 Thread Fu Wei
Hi Timur, On 4 February 2016 at 01:48, Timur Tabi wrote: > fu@linaro.org wrote: >> >> +static struct platform_driver sbsa_gwdt_driver = { >> + .driver = { >> + .name = "sbsa-gwdt", >> + .pm = &sbsa_gwdt_pm_ops, >> + .of_match_table = sbsa_gwdt_o

Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-03 Thread Timur Tabi
fu@linaro.org wrote: +static struct platform_driver sbsa_gwdt_driver = { + .driver = { + .name = "sbsa-gwdt", + .pm = &sbsa_gwdt_pm_ops, + .of_match_table = sbsa_gwdt_of_match, + }, + .probe = sbsa_gwdt_probe, + .remove = sbsa_

[PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

2016-02-03 Thread fu . wei
From: Fu Wei According to Server Base System Architecture (SBSA) specification, the SBSA Generic Watchdog has two stage timeouts: the first signal (WS0) is for alerting the system by interrupt, the second one (WS1) is a real hardware reset. This patch initially implements a simple single stage w