Re: [PATCH v10 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-19 Thread Uwe Kleine-König
On Tue, Mar 19, 2019 at 12:52:12PM +0530, Yash Shah wrote: > On Tue, Mar 19, 2019 at 3:16 AM Uwe Kleine-König > wrote: > > On Mon, Mar 18, 2019 at 05:17:14PM +0530, Yash Shah wrote: > > > + val = PWM_SIFIVE_PWMCFG_EN_ALWAYS | > > > + FIELD_PREP(PWM_SIFIVE_PWMCFG_SCALE, scale); > > >

Re: [PATCH v10 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-19 Thread Yash Shah
On Tue, Mar 19, 2019 at 3:16 AM Uwe Kleine-König wrote: > > Hello, > > [I put Thierry into To: because some remaining questions depend on his > views] > > On Mon, Mar 18, 2019 at 05:17:14PM +0530, Yash Shah wrote: > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > >

Re: [PATCH v10 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-18 Thread Uwe Kleine-König
Hello, [I put Thierry into To: because some remaining questions depend on his views] On Mon, Mar 18, 2019 at 05:17:14PM +0530, Yash Shah wrote: > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code clean

[PATCH v10 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-18 Thread Yash Shah
Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. Signed-off-by: Wesley W. Terpstra [Atish: Various fixes and code cleanup] Signed-off-by: Atish Patra Signed-off-by: Yash Shah --- drivers/pwm/Kconfig | 11 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-sifive