Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions

2014-12-14 Thread Jarkko Sakkinen
On Sun, Dec 14, 2014 at 04:31:10PM +0100, peterhu...@gmx.de wrote: > > > On 14. Dezember 2014 15:57:10 MEZ, Jarkko Sakkinen > wrote: > >On Sun, 2014-12-14 at 09:03 -0500, Stefan Berger wrote: > >> On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote: > >> > Merged transmit_cmd() functions in tpm-inter

Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions

2014-12-14 Thread peterhuewe
On 14. Dezember 2014 15:57:10 MEZ, Jarkko Sakkinen wrote: >On Sun, 2014-12-14 at 09:03 -0500, Stefan Berger wrote: >> On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote: >> > Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c. >> > Added "tpm_" prefix for consistency sake. Changed cm

Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions

2014-12-14 Thread Jarkko Sakkinen
On Sun, 2014-12-14 at 09:03 -0500, Stefan Berger wrote: > On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote: > > Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c. > > Added "tpm_" prefix for consistency sake. Changed cmd parameter as > > opaque. This enables to use separate command st

Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions

2014-12-14 Thread Stefan Berger
On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote: Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c. Added "tpm_" prefix for consistency sake. Changed cmd parameter as opaque. This enables to use separate command structures for TPM1 and TPM2 commands in future. Loose coupling works

[PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions

2014-12-12 Thread Jarkko Sakkinen
Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c. Added "tpm_" prefix for consistency sake. Changed cmd parameter as opaque. This enables to use separate command structures for TPM1 and TPM2 commands in future. Loose coupling works fine here. Signed-off-by: Jarkko Sakkinen Revie