Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-22 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Fri, Aug 21, 2015 at 09:54:49AM +0200, Ingo Molnar wrote: > > > > * Josh Poimboeuf wrote: > > > > > +Why do we need stack validation? > > > + > > > + > > > +Here are some of the benefits of validating stack metadata: > > > + > > > +

Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-21 Thread Josh Poimboeuf
On Fri, Aug 21, 2015 at 09:54:49AM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > +Why do we need stack validation? > > + > > + > > +Here are some of the benefits of validating stack metadata: > > + > > +a) More reliable stack traces for frame pointer

Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-21 Thread Ingo Molnar
* Josh Poimboeuf wrote: > +Why do we need stack validation? > + > + > +Here are some of the benefits of validating stack metadata: > + > +a) More reliable stack traces for frame pointer enabled kernels > + > + Frame pointers are used for debugging purposes. The

Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-19 Thread Josh Poimboeuf
On Wed, Aug 19, 2015 at 12:01:38PM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > On Sat, Aug 15, 2015 at 12:23:54AM -0700, Andrew Morton wrote: > > > On Thu, 13 Aug 2015 22:10:24 -0500 Josh Poimboeuf > > > wrote: > > > > > > > This adds a CONFIG_STACK_VALIDATION option which ena

Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-19 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Sat, Aug 15, 2015 at 12:23:54AM -0700, Andrew Morton wrote: > > On Thu, 13 Aug 2015 22:10:24 -0500 Josh Poimboeuf > > wrote: > > > > > This adds a CONFIG_STACK_VALIDATION option which enables a host tool > > > named stackvalidate which runs at compile time. > > >

Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-15 Thread Josh Poimboeuf
On Sat, Aug 15, 2015 at 12:23:54AM -0700, Andrew Morton wrote: > On Thu, 13 Aug 2015 22:10:24 -0500 Josh Poimboeuf wrote: > > > This adds a CONFIG_STACK_VALIDATION option which enables a host tool > > named stackvalidate which runs at compile time. > > It would be useful to > > - show example o

Re: [PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-15 Thread Andrew Morton
On Thu, 13 Aug 2015 22:10:24 -0500 Josh Poimboeuf wrote: > This adds a CONFIG_STACK_VALIDATION option which enables a host tool > named stackvalidate which runs at compile time. It would be useful to - show example output for a typical error site - describe the consequences of that error (ie:

[PATCH v10 03/20] x86/stackvalidate: Compile-time stack validation

2015-08-13 Thread Josh Poimboeuf
This adds a CONFIG_STACK_VALIDATION option which enables a host tool named stackvalidate which runs at compile time. It analyzes every .o file and ensures the validity of its stack metadata. It enforces a set of rules on asm code and C inline assembly code so that stack traces can be reliable. C